Improvement when there is no explicit Body in the request (take 2) #1424
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new eslint config - Update typescript to lates version - Resolve linting issues - Improve some tests so they throw an error instead of just failing by timeout - Delete stub file as it is not used - Remove stub mentions from the readme - Remove dangerous `clean` npm script - Remove unneded `prepare` npm script - Add build step to PR pipeline
w666
reviewed
Jan 10, 2026
Collaborator
w666
left a comment
w666
left a comment
There was a problem hiding this comment.
Yeah, this makes sense, I think it is okay to merge this without test. Left minor comment just to improve readability.
Co-authored-by: Vasily Martynov <[email protected]>
Co-authored-by: Vasily Martynov <[email protected]>
w666
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply reformats the OG PR using prettier and sync's with master to make it legible. There is no test, but the existing test pass. Not sure about the motivation. The author, @aurelmegn, says to "have improved the input request parsing when there is no explicit body in the initial request Xml." Perhaps they could clarify what changes. Not sure what to test for here either.
@w666 -- leaving up to you to decide what to do next -- merge this one, add a test, or simply close both...