Skip to content

Improvement when there is no explicit Body in the request (take 2) #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w666 merged 11 commits into from
Jan 12, 2026
Merged

Improvement when there is no explicit Body in the request (take 2) #1424

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
32c96fe
fix: set body to the parsed obj
aurelmegn Aug 18, 2022
b43d46e
fix: lookup for methodName with soapAction as suffix
aurelmegn Aug 18, 2022
6167383
fix pair
aurelmegn Aug 18, 2022
a71bda4
fix codestyle
aurelmegn Aug 18, 2022
9f94acd
Replace tslint with eslint (#1342)
w666 Sep 18, 2025
72ba2ed
[lint] copy linting and package-related changes from master
smokhov Jan 10, 2026
b1ce356
[lint] apply new formatting rules
smokhov Jan 10, 2026
0a62fe1
[lint] update tsconfig.json from master
smokhov Jan 10, 2026
87ab04e
Merge remote-tracking branch 'origin' into no-body-request-aurelmegn-…
smokhov Jan 10, 2026
e1b0bc5
declare return type in _getMethodNameBySoapAction()
smokhov Jan 10, 2026
3e14cfa
return null as appropriate
smokhov Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,17 @@ function getDateString(d) {
//eslint-disable-next-line @typescript-eslint/no-unsafe-declaration-merging
export interface Server {
emit(event: 'request', request: any, methodName: string): boolean;

emit(event: 'headers', headers: any, methodName: string): boolean;

emit(event: 'response', headers: any, methodName: string): boolean;

/** Emitted for every received messages. */
on(event: 'request', listener: (request: any, methodName: string) => void): this;

/** Emitted when the SOAP Headers are not empty. */
on(event: 'headers', listener: (headers: any, methodName: string) => void): this;

/** Emitted before sending SOAP response. */
on(event: 'response', listener: (response: any, methodName: string) => void): this;
}
Expand Down Expand Up @@ -285,7 +289,7 @@ export class Server extends EventEmitter {
private _process(input, req: Request, res: Response, cb: (result: any, statusCode?: number) => any) {
const pathname = url.parse(req.url).pathname.replace(/\/$/, '');
const obj = this.wsdl.xmlToObject(input);
const body = obj.Body;
const body = obj.Body ? obj.Body : obj;
const headers = obj.Header;
let binding: BindingElement;
let methodName: string;
Expand Down Expand Up @@ -353,9 +357,9 @@ export class Server extends EventEmitter {
try {
const soapAction = this._getSoapAction(req);
const messageElemName = Object.keys(body)[0] === 'attributes' ? Object.keys(body)[1] : Object.keys(body)[0];
const pair = binding.topElements[messageElemName];
const pair = binding.topElements[messageElemName] ? binding.topElements[messageElemName] : binding.topElements[soapAction];
if (soapAction) {
methodName = this._getMethodNameBySoapAction(binding, soapAction);
methodName = this._getMethodNameBySoapActionSuffix(binding, soapAction);
} else {
methodName = pair ? pair.methodName : messageElemName;
}
Expand Down Expand Up @@ -491,12 +495,27 @@ export class Server extends EventEmitter {
}
}

private _getMethodNameBySoapAction(binding: BindingElement, soapAction: string) {
private _getMethodNameBySoapActionSuffix(binding: BindingElement, soapAction: string): string | null {
const methodName = this._getMethodNameBySoapAction(binding, soapAction);

if (methodName) {
return methodName;
}
for (const methodName in binding.methods) {
const parts = binding.methods[methodName].soapAction.split('/');
if (parts.reverse()[0] === soapAction) {
return methodName;
}
}
}

private _getMethodNameBySoapAction(binding: BindingElement, soapAction: string): string | null {
for (const methodName in binding.methods) {
if (binding.methods[methodName].soapAction === soapAction) {
return methodName;
}
}
return null;
}

private _executeMethod(options: IExecuteMethodOptions, req: Request, res: Response, callback: (result: any, statusCode?: number) => any, includeTimestamp?) {
Expand Down