Skip to content

Conversation

@Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Jun 20, 2025

Summary

  • Also grant permissions to the public schema on the new databases. Uses a vshn fork of provider-sql for now, see the component PR linked below for more info.
  • It sets the custom user explicitly as the owner of the database.
  • Fixed a racecondition with the userpass, which can lead to empty passwords

Checklist

  • Update tests.
  • Link this PR to related issues.

Component PR: vshn/component-appcat#778

@Kidswiss Kidswiss added the minor label Jun 20, 2025
@Kidswiss Kidswiss changed the title Add/schema grants Grant permissions to the custom users on the public schema Jun 20, 2025
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@Kidswiss Kidswiss force-pushed the add/schema-grants branch from 39091a4 to 13d6b95 Compare June 23, 2025 07:11
@github-actions
Copy link
Contributor

@Kidswiss Kidswiss requested review from a team, TheBigLee, ThisIsntTheWay, wejdross and zugao and removed request for a team June 23, 2025 07:19
@@ -20,13 +20,19 @@ import (
"context"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file with all its contents will be injected into provider sql and as I understand more GRANTS will be issued is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy pasted direclty from the provider-sql. We import it to be able to create valid CRs for the provider.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you add those CRs in another PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is them being added :D

@github-actions
Copy link
Contributor

@Kidswiss Kidswiss merged commit b8a327a into develop Jun 24, 2025
9 checks passed
@zugao zugao deleted the add/schema-grants branch July 22, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants