Skip to content

Grant permissions to the custom users on the public schema #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kidswiss merged 2 commits into from
Jun 24, 2025
Merged

Grant permissions to the custom users on the public schema #778

Kidswiss merged 2 commits into from
Jun 24, 2025

Conversation

@vshnbot
Copy link
Collaborator

@vshnbot vshnbot commented Jun 20, 2025 •
edited
Loading

Summary

  • Also grant permissions to the public schema on the new databases. Uses a vshn fork of provider-sql for now, see the component PR linked below for more info.
  • It sets the custom user explicitly as the owner of the database.
  • Fixed a racecondition with the userpass, which can lead to empty passwords

Checklist

  • Update tests.
  • Link this PR to related issues.

Component PR: #778
Link: vshn/appcat#392

@github-actions github-actions bot mentioned this pull request Jun 20, 2025
Merged
2 tasks
@Kidswiss Kidswiss added the minor label Jun 20, 2025
@Kidswiss Kidswiss changed the title Add/schema grants Grant permissions to the custom users on the public schema Jun 20, 2025
@vshnbot vshnbot force-pushed the appcat/392/add/schema-grants branch from 89c8eee to 6724f9c Compare June 20, 2025 13:24
@Kidswiss Kidswiss force-pushed the appcat/392/add/schema-grants branch 2 times, most recently from 89c8eee to 1b8dadd Compare June 23, 2025 06:50
@vshnbot vshnbot force-pushed the appcat/392/add/schema-grants branch from 1b8dadd to f2f47ab Compare June 23, 2025 07:11
@Kidswiss Kidswiss force-pushed the appcat/392/add/schema-grants branch from f2f47ab to dd6b657 Compare June 23, 2025 07:25
Kidswiss
Kidswiss reviewed Jun 23, 2025
View reviewed changes
tests/golden/control-plane/appcat/appcat/20_xrd_vshn_keycloak.yaml
ClaimName specifies the name of the instance you want to restore from.
The claim has to be in the same namespace as this new instance.
type: string
claimType:
Copy link
Contributor

@Kidswiss Kidswiss Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated with my change.

@Kidswiss Kidswiss requested review from a team, Kidswiss, TheBigLee, mdnix and zugao and removed request for a team June 23, 2025 07:32
@vshnbot vshnbot force-pushed the appcat/392/add/schema-grants branch from dd6b657 to 1cb64d6 Compare June 24, 2025 07:06
@Kidswiss Kidswiss force-pushed the appcat/392/add/schema-grants branch 3 times, most recently from 14f8af2 to 5f3f11c Compare June 24, 2025 12:36
@Kidswiss Kidswiss force-pushed the appcat/392/add/schema-grants branch from 5f3f11c to dc0a674 Compare June 24, 2025 12:42
@Kidswiss Kidswiss merged commit 9ce8759 into develop Jun 24, 2025
12 checks passed
@Kidswiss Kidswiss deleted the appcat/392/add/schema-grants branch June 24, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdnix mdnix mdnix approved these changes

@Kidswiss Kidswiss Awaiting requested review from Kidswiss Kidswiss was automatically assigned from vshn/schedar

@zugao zugao Awaiting requested review from zugao zugao was automatically assigned from vshn/schedar

@TheBigLee TheBigLee Awaiting requested review from TheBigLee

Assignees

No one assigned

Labels

minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vshnbot @Kidswiss @mdnix