Fix race condition in initial-maintenance job creation#614
Merged
github-actions[bot] merged 1 commit intodevelopfrom Mar 12, 2026
Merged
Fix race condition in initial-maintenance job creation#614github-actions[bot] merged 1 commit intodevelopfrom
github-actions[bot] merged 1 commit intodevelopfrom
Conversation
mdnix
requested review from
a team,
Kidswiss,
TheBigLee,
mikeshootzz and
zugao
and removed request for
a team
3 tasks
Contributor
|
Kidswiss
approved these changes
Mar 12, 2026
mikeshootzz
approved these changes
Mar 12, 2026
Member
Author
|
/merge |
Contributor
Contributor
|
Contributor
|
Member
Author
|
/merge |
Contributor
mikeshootzz
pushed a commit
to vshn/component-appcat
that referenced
this pull request
Mar 24, 2026
…352b4a592ad35a45f9ecb2918a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the first reconcile, the composite resource metadata may not be fully populated yet, causing a job named just
initial-maintenanceinstead of{composite}-initial-maintenancewith empty env vars that fails immediately. The orphaned error pods triggerKubePodNotReadyalerts indefinitely.Defer job creation until
GetName()is non-empty. The next reconcile will have the full metadata.Checklist
/mergecomment.Component PR: vshn/component-appcat#1104