Skip to content

Fix race condition in initial-maintenance job creation #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Mar 12, 2026
Merged

Fix race condition in initial-maintenance job creation #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/comp-functions/functions/common/maintenance/maintenance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,11 @@ func (m *Maintenance) Run(ctx context.Context) *xfnproto.Result {
// Handle initial maintenance job
// Keep the job in desired state until 30 minutes after completion
if !m.resource.GetInitialMaintenanceRan() {
if m.resource.GetName() == "" {
log.Info("Composite resource not yet fully populated, deferring initial maintenance job")
return runtime.NewNormalResult("Composite resource not yet fully populated, deferring initial maintenance job")
}

// Job hasn't been created yet, create it
if err := m.createInitialMaintenanceJob(ctx); err != nil {
log.Error(err, "Failed to create initial maintenance job")
Expand Down
Loading