#177: Update SHACL-SHACL to review sh:singleLine usage
#463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some syntax style borrowed from Issue 449. References: * #449 Signed-off-by: Alex Nelson <[email protected]>
jeswr
approved these changes
Aug 4, 2025
TallTed
reviewed
Aug 6, 2025
| @@ -111,6 +111,7 @@ shsh:ShapeShape | |||
| sh:targetSubjectsOf sh:uniqueLang ; | |||
| sh:targetSubjectsOf sh:uniqueMembers ; | |||
| sh:targetSubjectsOf sh:xone ; | |||
| sh:targetSubjectsOf sh:singleLine ; | |||
There was a problem hiding this comment.
Should alignment of this line not match those above? I still hate tabs for this purpose, but it doesn't make sense to indent one line with two-spaces when the rest of its stanza has one-tab indents.
Suggested change
| sh:targetSubjectsOf sh:singleLine ; | |
| sh:targetSubjectsOf sh:singleLine ; |
TallTed
reviewed
Aug 6, 2025
| @@ -111,6 +111,7 @@ shsh:ShapeShape | |||
| sh:targetSubjectsOf sh:uniqueLang ; | |||
| sh:targetSubjectsOf sh:uniqueMembers ; | |||
| sh:targetSubjectsOf sh:xone ; | |||
| sh:targetSubjectsOf sh:singleLine ; | |||
|
|
|||
| sh:targetObjectsOf sh:memberShape ; # memberShape-node | |||
There was a problem hiding this comment.
I note that sh:targetSubjectsOf precedes sh:targetObjectsOf, so again, these documents can only be sorted one predicate at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-on to #268, and just updates SHACL-SHACL to test syntax for #177 .