Skip to content

#177: Update SHACL-SHACL to review sh:singleLine usage #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions shacl12-vocabularies/shacl-shacl.ttl
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ shsh:ShapeShape
sh:targetSubjectsOf sh:uniqueLang ;
sh:targetSubjectsOf sh:uniqueMembers ;
sh:targetSubjectsOf sh:xone ;
sh:targetSubjectsOf sh:singleLine ;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should alignment of this line not match those above? I still hate tabs for this purpose, but it doesn't make sense to indent one line with two-spaces when the rest of its stanza has one-tab indents.

Suggested change
sh:targetSubjectsOf sh:singleLine ;
sh:targetSubjectsOf sh:singleLine ;


sh:targetObjectsOf sh:memberShape ; # memberShape-node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that sh:targetSubjectsOf precedes sh:targetObjectsOf, so again, these documents can only be sorted one predicate at a time.

sh:targetObjectsOf sh:node ; # node-node
Expand Down Expand Up @@ -295,6 +296,11 @@ shsh:ShapeShape
sh:maxCount 1 ; # multiple-parameters
# Not implemented: syntax rule pattern-regex
] ;
sh:property [
sh:path sh:singleLine ;
sh:datatype xsd:boolean ; # singleLine-datatype
sh:maxCount 1 ; # multiple-parameters
] ;
sh:property [
sh:path sh:flags ;
sh:datatype xsd:string ; # flags-datatype
Expand Down