Skip to content

Conversation

@wallstop
Copy link
Owner

@wallstop wallstop commented Feb 1, 2026

Description

  • Skip scene assets when doing LoadAssetAtPath in DetectAssetChangePostProcessor
  • Add documentation URL to package.json
  • Update home page to github pages

Related Issue

Fixes #180
Fixes #181

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactor (code change that neither fixes a bug nor adds a feature)

Checklist

  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have updated the CHANGELOG
  • My changes do not introduce breaking changes, or breaking changes are documented

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug where Unity crashes when .unity or .scenetemplate files are processed by the DetectAssetChangeProcessor, along with documentation improvements to the package metadata.

Changes:

  • Fixed crash caused by calling LoadAllAssetsAtPath on scene files by adding scene path filtering
  • Added documentationUrl field to package.json pointing to GitHub Pages
  • Updated homepage URL in package.json to GitHub Pages
  • Updated version to 3.1.7 in package.json and banner SVG

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Bumped version to 3.1.7, added documentationUrl field, updated homepage to GitHub Pages
docs/images/unity-helpers-banner.svg Updated version number in banner to match package.json
Editor/AssetProcessors/DetectAssetChangeProcessor.cs Added IsScenePath helper method and scene file filtering before LoadAllAssetsAtPath calls
Tests/Editor/AssetProcessors/DetectAssetChangeProcessorTests.cs Added comprehensive tests for scene file processing including edge cases
CHANGELOG.md Documented the bug fix in Unreleased section

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

@wallstop wallstop merged commit 5da6a5b into main Feb 1, 2026
32 checks passed
@wallstop wallstop deleted the dev/wallstop/fix-asset-processor branch February 1, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Editor Complains "Do not use ReadObjectThreaded on scene objects! [Feature]: Documentation URL in package.json

2 participants