Fix reading multiline secrets (e.g. files) with op.read() #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side note:
I noticed that other places in the code use
rstrip('\n').But if an attached file acually ends with one or more line breaks, I think we want to leave them as they are and only remove the single trailing newline that the
opcli tool adds as a convenience for interactive use in the shell.For this, the method removesuffix, introduced in Python 3.9, is used instead of
rstrip, which removes all trailing linebreaks.Since I do not have enough context for the other usages of
rstripin the code, I can not say for certain, but I would think that they could also utiliseremovesuffixinstead.