Skip to content

Fix reading multiline secrets (e.g. files) with op.read() #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adnandaut wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix reading multiline secrets (e.g. files) with op.read() #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion onepassword/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ def read(secret_ref: str):
if not secret_ref or not isinstance(secret_ref, str):
raise ValueError("secret_ref must be a non-empty string")

return read_bash_return("op read '{}'".format(secret_ref))
return read_bash_return("op read '{}'".format(secret_ref), single=False).removesuffix('\n')

@staticmethod
def get_item_otp(uuid: str | bytes):
Expand Down