Skip to content

Reorder overloads to remove deprecation warning in pycharm #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dirkkul merged 2 commits into from
Dec 3, 2025
Merged

Reorder overloads to remove deprecation warning in pycharm #1901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c794247
Reorder overloads to remove deprecation warning in pycharm
dirkkul Dec 3, 2025
bbd4a80
Fix deprecation warning message
dirkkul Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions weaviate/collections/collections/async_.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ from weaviate.connect.v4 import ConnectionAsync

class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
@overload
@deprecated(
'Using the "vector_index_config" argument is deprecated. Instead, define the vector index for each specific vectorizer supplied to the "vectorizers_config" argument.'
)
async def create(
self,
name: str,
Expand All @@ -44,7 +41,7 @@ class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
replication_config: Optional[_ReplicationConfigCreate] = None,
reranker_config: Optional[_RerankerProvider] = None,
sharding_config: Optional[_ShardingConfigCreate] = None,
vector_index_config: _VectorIndexConfigCreate,
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
vectorizer_config: Optional[
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
] = None,
Expand All @@ -55,7 +52,7 @@ class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
) -> CollectionAsync[Properties, References]: ...
@overload
@deprecated(
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vectorizers_config" argument.'
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vector_config" argument.'
)
async def create(
self,
Expand All @@ -70,14 +67,19 @@ class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
replication_config: Optional[_ReplicationConfigCreate] = None,
reranker_config: Optional[_RerankerProvider] = None,
sharding_config: Optional[_ShardingConfigCreate] = None,
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
vectorizer_config: Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]],
vector_index_config: _VectorIndexConfigCreate,
vectorizer_config: Optional[
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
] = None,
vector_config: Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]] = None,
data_model_properties: Optional[Type[Properties]] = None,
data_model_references: Optional[Type[References]] = None,
skip_argument_validation: bool = False,
) -> CollectionAsync[Properties, References]: ...
@overload
@deprecated(
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vector_config" argument.'
)
async def create(
self,
name: str,
Expand All @@ -92,9 +94,7 @@ class _CollectionsAsync(_CollectionsBase[ConnectionAsync]):
reranker_config: Optional[_RerankerProvider] = None,
sharding_config: Optional[_ShardingConfigCreate] = None,
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
vectorizer_config: Optional[
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
] = None,
vectorizer_config: Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]],
vector_config: Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]] = None,
data_model_properties: Optional[Type[Properties]] = None,
data_model_references: Optional[Type[References]] = None,
Expand Down
20 changes: 10 additions & 10 deletions weaviate/collections/collections/sync.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ from weaviate.connect.v4 import ConnectionSync

class _Collections(_CollectionsBase[ConnectionSync]):
@overload
@deprecated(
'Using the "vector_index_config" argument is deprecated. Instead, define the vector index for each specific vectorizer supplied to the "vector_config" argument.'
)
def create(
self,
name: str,
Expand All @@ -44,7 +41,7 @@ class _Collections(_CollectionsBase[ConnectionSync]):
replication_config: Optional[_ReplicationConfigCreate] = None,
reranker_config: Optional[_RerankerProvider] = None,
sharding_config: Optional[_ShardingConfigCreate] = None,
vector_index_config: _VectorIndexConfigCreate,
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
vectorizer_config: Optional[
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
] = None,
Expand All @@ -55,7 +52,7 @@ class _Collections(_CollectionsBase[ConnectionSync]):
) -> Collection[Properties, References]: ...
@overload
@deprecated(
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vector_config" argument.'
'Using the "vector_index_config" argument is deprecated. Instead, define the vector index for each specific vectorizer supplied to the "vector_config" argument.'
)
def create(
self,
Expand All @@ -70,14 +67,19 @@ class _Collections(_CollectionsBase[ConnectionSync]):
replication_config: Optional[_ReplicationConfigCreate] = None,
reranker_config: Optional[_RerankerProvider] = None,
sharding_config: Optional[_ShardingConfigCreate] = None,
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
vectorizer_config: Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]],
vector_index_config: _VectorIndexConfigCreate,
vectorizer_config: Optional[
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
] = None,
vector_config: Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]] = None,
data_model_properties: Optional[Type[Properties]] = None,
data_model_references: Optional[Type[References]] = None,
skip_argument_validation: bool = False,
) -> Collection[Properties, References]: ...
@overload
@deprecated(
'Using the "vectorizer_config" argument is deprecated. Instead, use the "vector_config" argument.'
)
def create(
self,
name: str,
Expand All @@ -92,9 +94,7 @@ class _Collections(_CollectionsBase[ConnectionSync]):
reranker_config: Optional[_RerankerProvider] = None,
sharding_config: Optional[_ShardingConfigCreate] = None,
vector_index_config: Optional[_VectorIndexConfigCreate] = None,
vectorizer_config: Optional[
Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]]
] = None,
vectorizer_config: Union[_VectorizerConfigCreate, List[_NamedVectorConfigCreate]],
vector_config: Optional[Union[_VectorConfigCreate, List[_VectorConfigCreate]]] = None,
data_model_properties: Optional[Type[Properties]] = None,
data_model_references: Optional[Type[References]] = None,
Expand Down