Skip to content

Conversation

@dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Dec 3, 2025

Removes the

"Using the "vector_index_config" argument is deprecated. Instead, define the vector index for each specific vectorizer supplied to the "vector_config" argument. "

deprecation warning when creating a collection without vector indices

Copilot AI review requested due to automatic review settings December 3, 2025 07:45
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorders the @overload definitions for the create method in both sync and async collection stub files to eliminate deprecation warnings in PyCharm. The change follows Python typing best practices by placing the most general (non-deprecated) overload first, followed by more specific deprecated overloads.

  • Moved the non-deprecated overload (all parameters optional) to the first position
  • Placed deprecated overloads (with required vector_index_config or vectorizer_config) after the general overload
  • Swapped deprecation decorators and parameter requirements between overloads to maintain correct typing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
weaviate/collections/collections/sync.pyi Reordered three create method overloads: non-deprecated first, then two deprecated variants with specific required parameters
weaviate/collections/collections/async_.pyi Applied the same overload reordering as sync.pyi to maintain consistency between sync and async implementations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.55%. Comparing base (a788050) to head (bbd4a80).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1901   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files         273      273           
  Lines       19769    19769           
=======================================
  Hits        17112    17112           
  Misses       2657     2657           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dirkkul dirkkul merged commit fd52f50 into main Dec 3, 2025
127 checks passed
@dirkkul dirkkul deleted the order_overloads branch December 3, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants