Conversation
Spomky
force-pushed
the
features/credential-record
branch
3 times, most recently
from
53d4a16 to
65f5523
Compare
Spomky
force-pushed
the
features/credential-record
branch
from
ab837ba to
ecb1309
Compare
Contributor
|
Hi, @Spomky Thank you for your excellent changes 👍 This PR passes all my tests in my personal project(sorry, it's private 😞 ) after I adapted to the CredentialRecord. I'd like to help you review this MR if you want 😄 |
There was a problem hiding this comment.
Pull Request Overview
This PR implements a significant architectural change to align with the WebAuthn Level 3 specification by introducing CredentialRecord as a replacement for the deprecated PublicKeyCredentialSource. The migration maintains backward compatibility through union types and deprecation notices.
Key Changes:
- Introduces
CredentialRecordclass as the new standard for credential storage - Deprecates
PublicKeyCredentialSourcewith planned removal in version 6.0 - Updates all repository interfaces to support both types via union type declarations
- Adds
CredentialRecordConverterutility for bidirectional conversion - Updates event classes to use
credentialRecordproperty with backward-compatible access
Reviewed Changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/symfony/unit/Repository/RepositoryImplementationsTest.php | New comprehensive test suite verifying repository implementations support union types |
| tests/symfony/functional/Repository/RepositoryFunctionalTest.php | New functional tests for repository CRUD operations with both credential types |
| tests/symfony/functional/PublicKeyCredentialSourceRepository.php | Updated to accept union types in method signatures |
| tests/symfony/functional/CredentialRecordRepository.php | New test repository implementation for CredentialRecord |
| tests/library/Unit/RepositoryCompatibilityTest.php | New unit tests validating compatibility between credential types |
| tests/library/Unit/CredentialRecordTest.php | New test suite for CredentialRecord functionality |
| tests/library/Unit/CredentialRecordConverterTest.php | New tests for bidirectional credential conversion utility |
| tests/library/Functional/ValidatorCompatibilityTest.php | New functional tests ensuring validators work with both types |
| tests/library/Functional/BackupStateEventsTest.php | Updated to test deprecated property access via magic methods |
| tests/framework/MockedCredentialRecordTrait.php | New test trait for creating mock CredentialRecord instances |
| src/webauthn/src/CredentialRecord.php | New core class representing credential records per WebAuthn L3 spec |
| src/webauthn/src/Util/CredentialRecordConverter.php | New utility for converting between PublicKeyCredentialSource and CredentialRecord |
| src/webauthn/src/PublicKeyCredentialSource.php | Marked as deprecated with clear migration path |
| src/webauthn/src/Event/*.php | Updated event classes to use credentialRecord with backward-compatible accessors |
| src/webauthn/src/CeremonyStep/*.php | All ceremony steps updated to accept union types |
| src/webauthn/src/*Validator.php | Validators updated to work with both credential types |
| src/symfony/src/Repository/*.php | All repository interfaces and implementations updated for union type support |
| src/symfony/src/Security/*.php | Security components updated to handle both credential types |
| src/symfony/src/Resources/config/doctrine-mapping/CredentialRecord.orm.xml | New Doctrine mapping for CredentialRecord |
| docs/migration/credential-record-migration.md | Comprehensive migration guide with examples |
| CLAUDE.md | New developer documentation about the project architecture |
| .ci-tools/phpstan-baseline.neon | Updated baseline for deprecation warnings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target branch: 5.3.x
Resolves issue #717