perf: try to create native regex instead of regress regex #11292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
release: performance
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a performance optimization by implementing a hybrid regex approach that attempts to create native Rust regex first before falling back to the existing regress-based implementation. The change restructures RspackRegex from a single implementation to an enum that can handle both native and regress regex variants.
- Restructures
RspackRegexas an enum withRegex(native) andRegress(fallback) variants - Implements native regex creation with proper flag handling and error fallback
- Updates API consumers to use accessor methods instead of direct field access
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/rspack_regex/src/lib.rs | Core refactoring to enum-based approach with native regex priority |
| crates/rspack_regex/src/napi.rs | Updates to use accessor methods for flags and source |
| crates/rspack_regex/Cargo.toml | Adds regex dependency for native implementation |
| crates/rspack_binding_api/src/raw_options/raw_builtins/raw_lazy_compilation.rs | Updates to use accessor methods |
📦 Binary Size-limit
❌ Size increased by 142.25KB from 47.64MB to 47.78MB (⬆️0.29%) |
CodSpeed Performance ReportMerging #11292 will not alter performanceComparing 🎉 Hooray!
|
LingyuCoder
force-pushed
the
perf/native-regex-first
branch
from
76c0890 to
c65ed39
Compare
LingyuCoder
changed the title
LingyuCoder
changed the title
LingyuCoder
force-pushed
the
perf/native-regex-first
branch
from
a348c67 to
28dd463
Compare
|
📝 Benchmark detail: Open
Threshold exceeded: ["10000_production-mode_persistent-hot + exec"] |
quininer
reviewed
Aug 13, 2025
| // global: default in rust, ignore | ||
| 'g' => {} | ||
| // case-insensitive: letters match both upper and lower case | ||
| 'i' => applied_flags.push('i'), |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
algoand its fast path logic because native regex is fast enoughRelated links
Checklist