Skip to content

perf: try to create native regex instead of regress regex #11292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

perf: try to create native regex instead of regress regex #11292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6770a77
perf: create native regex first
LingyuCoder Aug 5, 2025
82e14a8
perf: try to create native regex first
LingyuCoder Aug 8, 2025
28dd463
perf: try to create native regex first
LingyuCoder Aug 8, 2025
85d2522
perf: try to create native regex first
LingyuCoder Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 14 additions & 18 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ prost = { version = "0.13", default-features = false }
quote = { version = "1.0.38", default-features = false }
rayon = { version = "1.10.0", default-features = false }
regex = { version = "1.11.1", default-features = false }
regex-syntax = { version = "0.8.5", default-features = false, features = ["std"] }
regress = { version = "0.10.4", default-features = false, features = ["pattern"] }
ropey = { version = "1.6.1", default-features = false }
rspack_resolver = { features = ["package_json_raw_json_api", "yarn_pnp"], version = "0.6.2", default-features = false }
Expand Down Expand Up @@ -123,20 +122,20 @@ inventory = { version = "0.3.17", default-features = false }
rkyv = { version = "=0.8.8", default-features = false, features = ["std", "bytecheck"] }

# Must be pinned with the same swc versions
pnp = { version = "0.12.1", default-features = false }
swc = { version = "34.0.0", default-features = false }
swc_config = { version = "3.1.1", default-features = false }
swc_core = { version = "35.0.0", default-features = false, features = ["parallel_rayon"] }
swc_ecma_lexer = { version = "22.0.0", default-features = false }
swc_ecma_minifier = { version = "29.0.0", default-features = false }
swc_error_reporters = { version = "16.0.1", default-features = false }
swc_html = { version = "25.0.0", default-features = false }
swc_html_minifier = { version = "29.0.0", default-features = false }
swc_node_comments = { version = "14.0.0", default-features = false }
swc_plugin_runner = { version = "18.0.0", default-features = false }

wasmtime = { version = "35.0.0", default-features = false }
wasi-common = { version = "35.0.0", default-features = false }
pnp = { version = "0.12.1", default-features = false }
swc = { version = "34.0.0", default-features = false }
swc_config = { version = "3.1.1", default-features = false }
swc_core = { version = "35.0.0", default-features = false, features = ["parallel_rayon"] }
swc_ecma_lexer = { version = "22.0.0", default-features = false }
swc_ecma_minifier = { version = "29.0.0", default-features = false }
swc_error_reporters = { version = "16.0.1", default-features = false }
swc_html = { version = "25.0.0", default-features = false }
swc_html_minifier = { version = "29.0.0", default-features = false }
swc_node_comments = { version = "14.0.0", default-features = false }
swc_plugin_runner = { version = "18.0.0", default-features = false }

wasi-common = { version = "35.0.0", default-features = false }
wasmtime = { version = "35.0.0", default-features = false }

rspack_dojang = { version = "0.1.11", default-features = false }

Expand Down Expand Up @@ -268,9 +267,6 @@ strip = "none"

[profile.release.package]

[profile.release.package.regex-syntax]
opt-level = "s"

[profile.release.package.swc_ecma_transforms_module]
opt-level = "s"

Expand Down
8 changes: 7 additions & 1 deletion crates/rspack/tests/snapshots/defaults__default_options.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
source: crates/rspack/tests/defaults.rs
assertion_line: 16
expression: options
---
CompilerOptions {
Expand Down Expand Up @@ -1404,6 +1403,13 @@ CompilerOptions {
),
wrapped_context_reg_exp: Some(
RspackRegex {
regex: Native(
RspackNativeRegex(
Regex(
".*",
),
),
),
flags: "",
source: ".*",
},
Expand Down
2 changes: 1 addition & 1 deletion crates/rspack_binding_api/src/raw_options/raw_builtins/raw_lazy_compilation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ impl From<RawLazyCompilationTest> for LazyCompilationTest<LazyCompilationTestFn>
fn from(value: RawLazyCompilationTest) -> Self {
match value.0 {
Either::A(regex) => Self::Regex(
RspackRegex::with_flags(&regex.source, &regex.flags).unwrap_or_else(|_| {
RspackRegex::with_flags(regex.source(), regex.flags()).unwrap_or_else(|_| {
let msg = format!("[lazyCompilation]incorrect regex {regex:?}");
panic!("{msg}");
}),
Expand Down
2 changes: 1 addition & 1 deletion crates/rspack_regex/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ version.workspace = true
[dependencies]
cow-utils = { workspace = true }
napi = { workspace = true }
regex-syntax = { workspace = true }
regex = { workspace = true }
regress = { workspace = true, features = ["backend-pikevm", "std"] }
rspack_cacheable = { workspace = true }
rspack_error = { workspace = true }
Expand Down
170 changes: 0 additions & 170 deletions crates/rspack_regex/src/algo.rs
View file
Open in desktop

This file was deleted.

Loading
Loading