Skip to content

refactor: use Arc<Dependency> to avoid clone#13152

Closed
hardfist wants to merge 1 commit intomainfrom
yj/arc-dependency
Closed

refactor: use Arc<Dependency> to avoid clone#13152
hardfist wants to merge 1 commit intomainfrom
yj/arc-dependency

Conversation

@hardfist
Copy link
Contributor

Summary

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: refactor team The issue/pr is created by the member of Rspack. labels Feb 28, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

📝 Benchmark detail: Open

Name Base (2026-02-28 10ed485) Current Change
10000_big_production-mode_disable-minimize + exec 13.9 s ± 327 ms 13.9 s ± 218 ms +0.01 %
10000_development-mode + exec 1.05 s ± 8 ms 1.06 s ± 24 ms +1.11 %
10000_development-mode_hmr + stats 197 ms ± 5.3 ms 197 ms ± 3.5 ms +0.26 %
10000_development-mode_noop-loader + exec 2.13 s ± 64 ms 2.11 s ± 28 ms -0.88 %
10000_production-mode + exec 1.15 s ± 40 ms 1.16 s ± 42 ms +0.85 %
10000_production-mode_persistent-cold + exec 1.34 s ± 50 ms 1.33 s ± 41 ms -0.46 %
10000_production-mode_persistent-hot + exec 971 ms ± 31 ms 969 ms ± 21 ms -0.19 %
10000_production-mode_source-map + exec 1.32 s ± 18 ms 1.34 s ± 37 ms +1.56 %
arco-pro_development-mode + exec 1.32 s ± 86 ms 1.32 s ± 33 ms -0.27 %
arco-pro_development-mode_hmr + stats 39 ms ± 1.2 ms 39 ms ± 1.2 ms -0.05 %
arco-pro_production-mode + exec 2.37 s ± 110 ms 2.36 s ± 76 ms -0.53 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 2.41 s ± 90 ms 2.44 s ± 87 ms +1.19 %
arco-pro_production-mode_persistent-cold + exec 2.47 s ± 69 ms 2.47 s ± 31 ms +0.12 %
arco-pro_production-mode_persistent-hot + exec 1.4 s ± 37 ms 1.4 s ± 46 ms +0.27 %
arco-pro_production-mode_source-map + exec 2.89 s ± 72 ms 2.93 s ± 99 ms +1.54 %
arco-pro_production-mode_traverse-chunk-modules + exec 2.42 s ± 133 ms 2.42 s ± 63 ms +0.02 %
bundled-threejs_development-mode + exec 194 ms ± 7 ms 193 ms ± 3.7 ms -0.52 %
bundled-threejs_production-mode + exec 227 ms ± 3.3 ms 228 ms ± 2 ms +0.71 %
large-dyn-imports_development-mode + exec 1.31 s ± 49 ms 1.31 s ± 23 ms -0.09 %
large-dyn-imports_production-mode + exec 1.4 s ± 21 ms 1.41 s ± 72 ms +0.89 %
threejs_development-mode_10x + exec 862 ms ± 9.6 ms 840 ms ± 21 ms -2.55 %
threejs_development-mode_10x_hmr + stats 136 ms ± 1.5 ms 139 ms ± 9.4 ms +1.91 %
threejs_production-mode_10x + exec 2.96 s ± 29 ms 2.95 s ± 38 ms -0.59 %
threejs_production-mode_10x_persistent-cold + exec 3.09 s ± 26 ms 3.07 s ± 34 ms -0.48 %
threejs_production-mode_10x_persistent-hot + exec 2.48 s ± 32 ms 2.48 s ± 33 ms +0.02 %
threejs_production-mode_10x_source-map + exec 3.7 s ± 45 ms 3.69 s ± 83 ms -0.30 %
10000_big_production-mode_disable-minimize + rss memory 2242 MiB ± 163 MiB 2324 MiB ± 285 MiB +3.64 %
10000_development-mode + rss memory 672 MiB ± 31.5 MiB 685 MiB ± 38.3 MiB +2.05 %
10000_development-mode_hmr + rss memory 854 MiB ± 22.6 MiB 863 MiB ± 23.4 MiB +0.99 %
10000_development-mode_noop-loader + rss memory 982 MiB ± 35.5 MiB 972 MiB ± 22.6 MiB -1.06 %
10000_production-mode + rss memory 558 MiB ± 16.2 MiB 556 MiB ± 24.8 MiB -0.46 %
10000_production-mode_persistent-cold + rss memory 780 MiB ± 36.8 MiB 789 MiB ± 25.7 MiB +1.08 %
10000_production-mode_persistent-hot + rss memory 767 MiB ± 19.7 MiB 777 MiB ± 19.3 MiB +1.24 %
10000_production-mode_source-map + rss memory 620 MiB ± 22.6 MiB 641 MiB ± 28.3 MiB +3.47 %
arco-pro_development-mode + rss memory 544 MiB ± 33.1 MiB 518 MiB ± 66.4 MiB -4.87 %
arco-pro_development-mode_hmr + rss memory 484 MiB ± 15.5 MiB 482 MiB ± 8.1 MiB -0.23 %
arco-pro_production-mode + rss memory 609 MiB ± 36 MiB 598 MiB ± 41.3 MiB -1.76 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 629 MiB ± 48.1 MiB 602 MiB ± 23.1 MiB -4.20 %
arco-pro_production-mode_persistent-cold + rss memory 681 MiB ± 40.8 MiB 659 MiB ± 24.7 MiB -3.20 %
arco-pro_production-mode_persistent-hot + rss memory 433 MiB ± 60.6 MiB 436 MiB ± 70.3 MiB +0.72 %
arco-pro_production-mode_source-map + rss memory 697 MiB ± 50.4 MiB 714 MiB ± 30.4 MiB +2.46 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 604 MiB ± 63.6 MiB 591 MiB ± 45.4 MiB -2.18 %
bundled-threejs_development-mode + rss memory 173 MiB ± 4.89 MiB 170 MiB ± 5.44 MiB -1.93 %
bundled-threejs_production-mode + rss memory 199 MiB ± 10.4 MiB 195 MiB ± 20.1 MiB -2.12 %
large-dyn-imports_development-mode + rss memory 694 MiB ± 15.5 MiB 693 MiB ± 27.4 MiB -0.15 %
large-dyn-imports_production-mode + rss memory 495 MiB ± 6.7 MiB 497 MiB ± 9.41 MiB +0.29 %
threejs_development-mode_10x + rss memory 535 MiB ± 25.4 MiB 532 MiB ± 19 MiB -0.51 %
threejs_development-mode_10x_hmr + rss memory 652 MiB ± 22 MiB 650 MiB ± 16.4 MiB -0.37 %
threejs_production-mode_10x + rss memory 651 MiB ± 18.2 MiB 650 MiB ± 17.7 MiB -0.07 %
threejs_production-mode_10x_persistent-cold + rss memory 794 MiB ± 7.68 MiB 777 MiB ± 21.3 MiB -2.14 %
threejs_production-mode_10x_persistent-hot + rss memory 642 MiB ± 15.9 MiB 630 MiB ± 9.3 MiB -1.86 %
threejs_production-mode_10x_source-map + rss memory 724 MiB ± 61.9 MiB 703 MiB ± 89.8 MiB -3.00 %

@github-actions
Copy link
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 825.4 KB 0
react-5k 2.7 MB 0
ui-components 2.2 MB 0
rome 984.2 KB 0

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

📦 Binary Size-limit

Comparing db85469 to perf: remove ProcessUnlazyDependenciesTask (#13151) by hardfist

❌ Size increased by 5.38KB from 48.89MB to 48.89MB (⬆️0.01%)

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing yj/arc-dependency (db85469) with main (fe401a7)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@hardfist hardfist closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: refactor team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant