Skip to content

perf: avoid create new dependency for add include#9505

Merged
ahabhgk merged 2 commits intomainfrom
add-include-dep-cache
Feb 28, 2025
Merged

perf: avoid create new dependency for add include#9505
ahabhgk merged 2 commits intomainfrom
add-include-dep-cache

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Feb 27, 2025

Summary

avoid create new dependency for add include, incremental make uses dependency id to determine whether the dependency can avoid rebuild or not

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 27, 2025
@netlify
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 4d3782f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67c15a42acc2a40008826a1b

@ahabhgk ahabhgk requested a review from SyMind February 27, 2025 12:34
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 27, 2025

CodSpeed Performance Report

Merging #9505 will not alter performance

Comparing add-include-dep-cache (4d3782f) with main (423fd69)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@ahabhgk ahabhgk force-pushed the add-include-dep-cache branch from c6b9fa8 to 4d3782f Compare February 28, 2025 06:40
@ahabhgk ahabhgk enabled auto-merge (squash) February 28, 2025 06:40
@ahabhgk ahabhgk merged commit e875ced into main Feb 28, 2025
27 checks passed
@ahabhgk ahabhgk deleted the add-include-dep-cache branch February 28, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants