chore(mdx): revert containerSynatx unknown types error #2764
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
SoonIter
November 14, 2025 08:20
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the behavior when an unknown container directive type is encountered in MDX from throwing an error to logging a warning instead.
- Changed error handling for unknown container types to use
logger.warninstead of throwing - Added import for
loggerfrom@rsbuild/core - Commented out the test that verified the error-throwing behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/node/mdx/remarkPlugins/containerSyntax.ts | Changed from throwing an error to logging a warning for unknown container types, added logger import |
| packages/core/src/node/mdx/remarkPlugins/containerSyntax.test.ts | Commented out test that verified error-throwing behavior for unknown types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Rsdoctor Bundle Diff Analysis
Generated by Rsdoctor Action |
SoonIter
changed the title
SoonIter
changed the title
Timeless0911
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
chore(mdx): switch containerSynatx unknown types error to warn
Related Issue
#2762
#2708
Checklist