Skip to content

chore(mdx): revert containerSynatx unknown types error #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2025
+17 −16
Merged

chore(mdx): revert containerSynatx unknown types error #2764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a37f8da
chore: switch containerSynatx error to warn
SoonIter Nov 14, 2025
98eaa89
chore: udpate
SoonIter Nov 14, 2025
9acbaf8
chore: udpate
SoonIter Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/core/src/node/mdx/remarkPlugins/containerSyntax.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,17 +333,17 @@ Line 2 with [link](http://example.com).
expect(result).toMatchSnapshot();
});

test('error when container type is unknown', async () => {
await expect(
process(`
:::Tip
This is a tip.
:::
`),
).rejects.toThrow(
'[remarkContainerSyntax] Unknown container directive type "Tip". Supported types: tip, note, warning, caution, danger, info, details',
);
});
// test('error when container type is unknown', async () => {
// await expect(
// process(`
// :::Tip
// This is a tip.
// :::
// `),
// ).rejects.toThrow(
// '[remarkContainerSyntax] Unknown container directive type "Tip". Supported types: tip, note, warning, caution, danger, info, details',
// );
// });

test('empty blockquote', async () => {
const result = await process(`
Expand Down
11 changes: 6 additions & 5 deletions packages/core/src/node/mdx/remarkPlugins/containerSyntax.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const TITLE_REGEX_IN_MD = /{\s*title=["']?(.+)}\s*/;
export const TITLE_REGEX_IN_MDX = /\s*title=["']?(.+)\s*/;

const CALLOUT_COMPONENT = '$$$callout$$$'; // in md, we can not add import statement, so we use a special component name to avoid conflict with user components
const ERROR_PREFIX = '[remarkContainerSyntax]';
// const ERROR_PREFIX = '[remarkContainerSyntax]';

export type DirectiveType = (typeof DIRECTIVE_TYPES)[number];

Expand Down Expand Up @@ -376,10 +376,11 @@ export const remarkContainerSyntax: Plugin<[], Root> = () => {
return;
}
unknownTypes.add(type);
const supportedTypes = DIRECTIVE_TYPES.join(', ');
throw new Error(
`${ERROR_PREFIX} Unknown container directive type "${type}". Supported types: ${supportedTypes}`,
);
// FIXME: add panic after remark-directive
// const supportedTypes = DIRECTIVE_TYPES.join(', ');
// logger.warn(
// `${ERROR_PREFIX} Unknown container directive type "${type}". Supported types: ${supportedTypes}`,
// );
};

return tree => {
Expand Down
Loading