[Gecko Bug 1981664] Allow wpt reftest to avoid caching screenshots #54187
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful if we have a stateful issue where e.g. font rendering may change between tests, so a test compared with a screenshot of the same reference taken for an earlier test might fail. Clearly in such a situation we should fix the underlying bug, but disabling caches is preferable to mistakenly classifying many tests as failing. In addition, disable screenshot caches for Android 14, since that platform seems to have such an issue. Differential Revision: https://phabricator.services.mozilla.com/D260245 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1981664 gecko-commit: 40ef569ca4d81bdbc49933c704b3f0a6076bb1eb gecko-reviewers: Sasha, webdriver-reviewers
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful if we have a stateful issue where e.g. font rendering
may change between tests, so a test compared with a screenshot
of the same reference taken for an earlier test might fail.
Clearly in such a situation we should fix the underlying bug, but
disabling caches is preferable to mistakenly classifying many tests as
failing.
In addition, disable screenshot caches for Android 14, since that
platform seems to have such an issue.
Differential Revision: https://phabricator.services.mozilla.com/D260245
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1981664
gecko-commit: 40ef569ca4d81bdbc49933c704b3f0a6076bb1eb
gecko-reviewers: Sasha, webdriver-reviewers