Skip to content

[Gecko Bug 1981664] Allow wpt reftest to avoid caching screenshots #54187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tools/wptrunner/wptrunner/browsers/firefox.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,15 @@ def executor_kwargs(logger, test_type, test_environment, run_info_data,
capabilities["pageLoadStrategy"] = "eager"
if test_type in ("reftest", "print-reftest"):
executor_kwargs["reftest_internal"] = kwargs["reftest_internal"]
cache_screenshots = True
if run_info_data["os"] == "android":
try:
major_version = int(run_info_data["version"].split(".", 1)[0])
except ValueError:
pass
else:
cache_screenshots = major_version < 14
executor_kwargs["cache_screenshots"] = cache_screenshots
if test_type == "wdspec":
options = {"args": []}
if kwargs["binary"]:
Expand Down
12 changes: 9 additions & 3 deletions tools/wptrunner/wptrunner/executors/executormarionette.py
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,8 @@ def __init__(self, logger, browser, server_config, timeout_multiplier=1,
debug_info=None, reftest_internal=False,
reftest_screenshot="unexpected", ccov=False,
group_metadata=None, capabilities=None, debug=False,
browser_version=None, debug_test=False, **kwargs):
browser_version=None, debug_test=False,
cache_screenshots=True, **kwargs):
"""Marionette-based executor for reftests"""
RefTestExecutor.__init__(self,
logger,
Expand All @@ -1082,6 +1083,7 @@ def __init__(self, logger, browser, server_config, timeout_multiplier=1,
self.group_metadata = group_metadata
self.debug = debug
self.debug_test = debug_test
self.cache_screenshots = cache_screenshots

self.install_extensions = browser.extensions

Expand Down Expand Up @@ -1225,7 +1227,9 @@ def logger(self):
return self.executor.logger

def setup(self, screenshot="unexpected", chrome_scope=False):
data = {"screenshot": screenshot, "isPrint": self.executor.is_print}
data = {"screenshot": screenshot,
"isPrint": self.executor.is_print,
"cacheScreenshots": self.executor.cache_screenshots}
if self.executor.group_metadata is not None:
data["urlCount"] = {urljoin(self.executor.server_url(key[0]), key[1]):value
for key, value in self.executor.group_metadata.get("url_count", {}).items()
Expand All @@ -1234,6 +1238,7 @@ def setup(self, screenshot="unexpected", chrome_scope=False):
if chrome_scope:
self.logger.debug("Using marionette Chrome scope for reftests")
self.executor.protocol.marionette.set_context(self.executor.protocol.marionette.CONTEXT_CHROME)
self.logger.debug(f"Starting internal reftests with {data}")
self.executor.protocol.marionette._send_message("reftest:setup", data)

def reset(self, **kwargs):
Expand Down Expand Up @@ -1357,7 +1362,7 @@ def __init__(self, logger, browser, server_config, timeout_multiplier=1,
screenshot_cache=None, close_after_done=True,
debug_info=None, reftest_screenshot="unexpected", ccov=False,
group_metadata=None, capabilities=None, debug=False,
reftest_internal=False, **kwargs):
reftest_internal=False, cache_screenshots=True, **kwargs):
"""Marionette-based executor for reftests"""
MarionetteRefTestExecutor.__init__(self,
logger,
Expand All @@ -1373,6 +1378,7 @@ def __init__(self, logger, browser, server_config, timeout_multiplier=1,
group_metadata=group_metadata,
capabilities=capabilities,
debug=debug,
cache_screenshots=cache_screenshots,
**kwargs)

def setup(self, runner, protocol=None):
Expand Down
Loading