Skip to content

Conversation

@gnarf
Copy link
Contributor

@gnarf gnarf commented Nov 20, 2025

Was a little mixed about css/css-break/ruby* and css/css/css-ui/text-overflow-ruby.html - but <ruby> tags are spread out a bit, wondering a little if others should be classified.

Greps:

- ruby-position*
- name: ruby-overhang
files:
- ruby-overhang*
Copy link
Contributor

@jcscottiii jcscottiii Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment at the end? The comment should mention the need to add an exclusion rule to ruby to prevent double counting.

This will be helpful in the future for other IDs. (I know we do this for other PRs [1]. But given there are so many feature entries in this one, it would be helpful in case they don't see the ruby one at the top.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a situation that should probably be caught by lint / file matching tests in the long run, I'd be happy to add a comment though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants