Skip to content

Classify ruby & ruby-overhang web features #56156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Classify ruby & ruby-overhang web features #56156

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e2b75
Classify ruby & ruby-overhang web features
gnarf Nov 20, 2025
4caaa99
add a requested comment
gnarf Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions css/css-ruby/WEB_FEATURES.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
features:
- name: ruby
files:
- "!ruby-align-*"
- "!ruby-position*"
- "!ruby-overhang*"
- "*"
- name: ruby-align
files:
- ruby-align-*
- name: ruby-position
files:
- ruby-position*
- name: ruby-overhang
files:
- ruby-overhang*
Copy link
Contributor

@jcscottiii jcscottiii Nov 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment at the end? The comment should mention the need to add an exclusion rule to ruby to prevent double counting.

This will be helpful in the future for other IDs. (I know we do this for other PRs [1]. But given there are so many feature entries in this one, it would be helpful in case they don't see the ruby one at the top.)

Copy link
Contributor Author

@gnarf gnarf Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a situation that should probably be caught by lint / file matching tests in the long run, I'd be happy to add a comment though.