Remove commons lang3 dependency and update dependencies #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgala
force-pushed
the
remove-commons-lang3-dependency
branch
from
e14fa84 to
7f71544
Compare
honza-kasik
reviewed
Apr 3, 2024
Contributor
honza-kasik
left a comment
honza-kasik
left a comment
There was a problem hiding this comment.
Thanks, code LGTM (just one question), but it would be handy to try this out in noe-tests.
| // Is realm's authentication undefined? | ||
| if (CLILib.readArbitraryCommandOutput(securityRealmBuilder.as7serverInstance, cmdStrReadMgt) =~ /${securityRealmBuilder.name}[[^\n]*\n]*authentication[ "=>\{\n]*undefined/) { | ||
| if (StringUtils.isBlank(securityRealmBuilder.truststoreAbsolutePath) || StringUtils.isBlank(securityRealmBuilder.truststorePassword)) throw new IllegalArgumentException("One must set both TruststoreAbsolutePath and TruststorePassword.") | ||
| if (securityRealmBuilder.truststoreAbsolutePath?.allWhitespace || securityRealmBuilder.truststorePassword.isBlank()) throw new IllegalArgumentException("One must set both TruststoreAbsolutePath and TruststorePassword.") |
Contributor
There was a problem hiding this comment.
isBlank() for securityRealmBuilder.truststorePasswor is intentional here?
Contributor
Author
There was a problem hiding this comment.
Nice catch, I missed it in my last edit. Apparently the integration tests didn't catch it! I'm fixing it as I rebase.
sgala
force-pushed
the
remove-commons-lang3-dependency
branch
from
62e9b0e to
dc31088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove commons-lang3 dependency and update binary dependencies to the versions in pom.xml.
Also, revert jgit 6.x dependency that requires jdk-11, while current groovy version requires 1.8