Skip to content

Remove commons lang3 dependency and update dependencies #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove commons lang3 dependency and update dependencies #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-collections4</artifactId>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
</dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
Expand Down
3 changes: 1 addition & 2 deletions core/src/main/groovy/noe/common/utils/VerifyURLBuilder.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import com.gargoylesoftware.htmlunit.Page
import com.gargoylesoftware.htmlunit.WebClient
import com.gargoylesoftware.htmlunit.WebResponse
import groovy.util.logging.Slf4j
import org.apache.commons.lang3.StringUtils

import java.util.regex.Pattern

Expand Down Expand Up @@ -252,7 +251,7 @@ public final class VerifyURLBuilder {
*/
private Map build() {
if (url == null) throw new IllegalArgumentException("URL must not be null.")
if (StringUtils.isBlank(reqKey) != StringUtils.isBlank(reqValue)) {
if (reqKey?.allWhitespace != reqValue?.allWhitespace) {
throw new IllegalArgumentException("ReqKey and ReqValue have to have to be either both set or both empty.")
}

Expand Down
Loading