Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project README header to use a centered, “for-the-badge” style badge row and to show compatibility/status information more prominently.
Changes:
- Replaced the existing Markdown badges with an HTML badge block for Filament versions, Packagist version/downloads, and CI workflow statuses.
- Added Filament 3.x/4.x/5.x badges linking to the corresponding Filament documentation pages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
+23
| <img alt="Tests Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/run-tests.yml?style=for-the-badge&logo=github&label=tests"> | ||
| </a> | ||
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Aphpstan+branch%3Av3" class="filament-hidden"> | ||
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan"> | ||
| </a> | ||
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Arector+branch%3Av3" class="filament-hidden"> | ||
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector"> |
There was a problem hiding this comment.
The workflow status badge URL does not specify a branch, but the link targets results for branch:v3. As written, the badge will show the status of the repository’s default branch, which can be misleading. Add the branch=v3 parameter to the shields.io URL (or otherwise align badge and link to the same branch).
Suggested change
| <img alt="Tests Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/run-tests.yml?style=for-the-badge&logo=github&label=tests"> | |
| </a> | |
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Aphpstan+branch%3Av3" class="filament-hidden"> | |
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan"> | |
| </a> | |
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Arector+branch%3Av3" class="filament-hidden"> | |
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector"> | |
| <img alt="Tests Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/run-tests.yml?style=for-the-badge&logo=github&label=tests&branch=v3"> | |
| </a> | |
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Aphpstan+branch%3Av3" class="filament-hidden"> | |
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan&branch=v3"> | |
| </a> | |
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Arector+branch%3Av3" class="filament-hidden"> | |
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector&branch=v3"> |
| <img alt="Tests Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/run-tests.yml?style=for-the-badge&logo=github&label=tests"> | ||
| </a> | ||
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Aphpstan+branch%3Av3" class="filament-hidden"> | ||
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan"> |
There was a problem hiding this comment.
The PHPStan workflow status badge URL doesn’t include a branch parameter, so it will reflect the default branch even though the anchor links to branch:v3. Update the badge URL to explicitly target the same branch as the link.
Suggested change
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan"> | |
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?branch=v3&style=for-the-badge&logo=github&label=phpstan"> |
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan"> | ||
| </a> | ||
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Arector+branch%3Av3" class="filament-hidden"> | ||
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector"> |
There was a problem hiding this comment.
The Rector workflow status badge is missing a branch parameter, which means the badge may not match the branch:v3 results linked in the anchor. Pin the badge to the same branch to avoid showing an incorrect status.
Suggested change
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector"> | |
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector&branch=v3"> |
Comment on lines
+3
to
+17
| <p align="center" class="flex items-center justify-center"> | ||
| <a href="https://filamentphp.com/docs/3.x/introduction/overview"> | ||
| <img alt="FILAMENT 3.x" src="https://img.shields.io/badge/FILAMENT-3.x-EBB304?style=for-the-badge"> | ||
| </a> | ||
| <a href="https://filamentphp.com/docs/4.x/introduction/overview"> | ||
| <img alt="FILAMENT 4.x" src="https://img.shields.io/badge/FILAMENT-4.x-EBB304?style=for-the-badge"> | ||
| </a> | ||
| <a href="https://filamentphp.com/docs/5.x/introduction/overview"> | ||
| <img alt="FILAMENT 5.x" src="https://img.shields.io/badge/FILAMENT-5.x-EBB304?style=for-the-badge"> | ||
| </a> | ||
| <a href="https://packagist.org/packages/webard/filament-translatable"> | ||
| <img alt="Packagist" src="https://img.shields.io/packagist/v/webard/filament-translatable.svg?style=for-the-badge&logo=packagist"> | ||
| </a> | ||
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Arun-tests+branch%3Av3" class="filament-hidden"> | ||
| <img alt="Tests Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/run-tests.yml?style=for-the-badge&logo=github&label=tests"> |
There was a problem hiding this comment.
The class attributes here (e.g., flex items-center justify-center, filament-hidden) won’t have any effect in GitHub/Packagist Markdown rendering and may be stripped by sanitizers, making the markup harder to reason about. Consider removing the classes and relying on supported attributes (e.g., align) to keep the README portable.
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector"> | ||
| </a> | ||
| <a href="https://packagist.org/packages/webard/filament-translatable"> | ||
| <img alt="Downloads" src="https://img.shields.io/packagist/dt/webard/filament-translatable.svg?style=for-the-badge" > |
There was a problem hiding this comment.
There’s an extra space before the closing > on this <img> tag. It’s valid HTML, but trimming it keeps the README markup consistent and avoids unnecessary diffs in the future.
Suggested change
| <img alt="Downloads" src="https://img.shields.io/packagist/dt/webard/filament-translatable.svg?style=for-the-badge" > | |
| <img alt="Downloads" src="https://img.shields.io/packagist/dt/webard/filament-translatable.svg?style=for-the-badge"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.