-
Notifications
You must be signed in to change notification settings - Fork 1
New readme badges #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,10 +1,31 @@ | ||||||||||||||||||||||||||||||||||
| # Filament Translatable | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| [](https://packagist.org/packages/webard/filament-translatable) | ||||||||||||||||||||||||||||||||||
| [](https://packagist.org/packages/webard/filament-translatable) | ||||||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||||||
|  | ||||||||||||||||||||||||||||||||||
| <p align="center" class="flex items-center justify-center"> | ||||||||||||||||||||||||||||||||||
| <a href="https://filamentphp.com/docs/3.x/introduction/overview"> | ||||||||||||||||||||||||||||||||||
| <img alt="FILAMENT 3.x" src="https://img.shields.io/badge/FILAMENT-3.x-EBB304?style=for-the-badge"> | ||||||||||||||||||||||||||||||||||
| </a> | ||||||||||||||||||||||||||||||||||
| <a href="https://filamentphp.com/docs/4.x/introduction/overview"> | ||||||||||||||||||||||||||||||||||
| <img alt="FILAMENT 4.x" src="https://img.shields.io/badge/FILAMENT-4.x-EBB304?style=for-the-badge"> | ||||||||||||||||||||||||||||||||||
| </a> | ||||||||||||||||||||||||||||||||||
| <a href="https://filamentphp.com/docs/5.x/introduction/overview"> | ||||||||||||||||||||||||||||||||||
| <img alt="FILAMENT 5.x" src="https://img.shields.io/badge/FILAMENT-5.x-EBB304?style=for-the-badge"> | ||||||||||||||||||||||||||||||||||
| </a> | ||||||||||||||||||||||||||||||||||
| <a href="https://packagist.org/packages/webard/filament-translatable"> | ||||||||||||||||||||||||||||||||||
| <img alt="Packagist" src="https://img.shields.io/packagist/v/webard/filament-translatable.svg?style=for-the-badge&logo=packagist"> | ||||||||||||||||||||||||||||||||||
| </a> | ||||||||||||||||||||||||||||||||||
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Arun-tests+branch%3Av3" class="filament-hidden"> | ||||||||||||||||||||||||||||||||||
| <img alt="Tests Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/run-tests.yml?style=for-the-badge&logo=github&label=tests"> | ||||||||||||||||||||||||||||||||||
| </a> | ||||||||||||||||||||||||||||||||||
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Aphpstan+branch%3Av3" class="filament-hidden"> | ||||||||||||||||||||||||||||||||||
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan"> | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan"> | |
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?branch=v3&style=for-the-badge&logo=github&label=phpstan"> |
Comment on lines
+17
to
+23
Copilot
AI
Jan 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow status badge URL does not specify a branch, but the link targets results for branch:v3. As written, the badge will show the status of the repository’s default branch, which can be misleading. Add the branch=v3 parameter to the shields.io URL (or otherwise align badge and link to the same branch).
Suggested change
| <img alt="Tests Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/run-tests.yml?style=for-the-badge&logo=github&label=tests"> | |
| </a> | |
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Aphpstan+branch%3Av3" class="filament-hidden"> | |
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan"> | |
| </a> | |
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Arector+branch%3Av3" class="filament-hidden"> | |
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector"> | |
| <img alt="Tests Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/run-tests.yml?style=for-the-badge&logo=github&label=tests&branch=v3"> | |
| </a> | |
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Aphpstan+branch%3Av3" class="filament-hidden"> | |
| <img alt="PHPStan Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/phpstan.yml?style=for-the-badge&logo=github&label=phpstan&branch=v3"> | |
| </a> | |
| <a href="https://github.com/webard/filament-translatable/actions?query=workflow%3Arector+branch%3Av3" class="filament-hidden"> | |
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector&branch=v3"> |
Copilot
AI
Jan 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rector workflow status badge is missing a branch parameter, which means the badge may not match the branch:v3 results linked in the anchor. Pin the badge to the same branch to avoid showing an incorrect status.
Suggested change
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector"> | |
| <img alt="Rector Passing" src="https://img.shields.io/github/actions/workflow/status/webard/filament-translatable/rector.yml?style=for-the-badge&logo=github&label=rector&branch=v3"> |
Copilot
AI
Jan 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s an extra space before the closing > on this <img> tag. It’s valid HTML, but trimming it keeps the README markup consistent and avoids unnecessary diffs in the future.
Suggested change
| <img alt="Downloads" src="https://img.shields.io/packagist/dt/webard/filament-translatable.svg?style=for-the-badge" > | |
| <img alt="Downloads" src="https://img.shields.io/packagist/dt/webard/filament-translatable.svg?style=for-the-badge"> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
classattributes here (e.g.,flex items-center justify-center,filament-hidden) won’t have any effect in GitHub/Packagist Markdown rendering and may be stripped by sanitizers, making the markup harder to reason about. Consider removing the classes and relying on supported attributes (e.g.,align) to keep the README portable.