Skip to content

Conversation

fosscel
Copy link
Contributor

@fosscel fosscel commented Jun 5, 2025

possible duplicate/necrobump of #4129, resolves #4128

as mentioned in #4129, #4030 introduced a bug that uploads the entire buffer, resulting in null bytes being appended to all files.
this reverts that change, as well as changing to call the overloaded RequestBody.fromString().

before the fix:
image

after the fix:
image

access volume looks normal, tested on a fresh world against an initially empty minio bucket:
image

@MoNoLidThZ
Copy link

MoNoLidThZ commented Jun 7, 2025

Thank you for providing this fix to the S3 output issue!

I’ve tested it with my own setup, and it resolves the problem with the extra null characters breaking JSON files.

For anyone interested, here's a live demo using this patch.

If you’re unable to build the patched version yourself, I’ve also provided a compiled JAR from my Jenkins CI instance.

Disclaimer: Always be cautious when downloading JAR files from third parties. I’ve tested this build on my own production server, but please verify and use at your own discretion. The build is provided solely for convenience.

@fosscel
Copy link
Contributor Author

fosscel commented Jun 11, 2025

@MoNoLidThZ I was dogfooding this and encountered #4217 , which I resolved in #4218
currently I'm using this branch in my fork that has both of these changes incorporated, if you're interested.

@mikeprimm mikeprimm merged commit 76f381e into webbukkit:v3.0 Jul 9, 2025
@mikeprimm
Copy link
Member

Looks good - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hosting on S3 - Null control characters at EOF
3 participants