Remove pass-by-reference for $result in ReferenceExecutor

[spawnia]

Follows up on #1776 (comment)

[spawnia]

Tests pass, I don't see how this change could be problematic.

[ruudk]

Since the ReferenceExecutor is not final, one could be extending it.

For example:

final class TestReferenceExecutor extends ReferenceExecutor {
    protected function completeAbstractValue(
        AbstractType $returnType,
        \ArrayObject $fieldNodes,
        ResolveInfo $info,
        array $path,
        array $unaliasedPath,
        &$result,
        $contextValue)
    {
        return parent::completeAbstractValue(
            $returnType,
            $fieldNodes,
            $info,
            $path,
            $unaliasedPath,
            $result,
            $contextValue,
        );
    }
}

This would fail now:

Declaration should be compatible with ReferenceExecutor->completeAbstractValue(returnType: \GraphQL\Type\Definition\AbstractType|\GraphQL\Type\Definition\Type&\GraphQL\Type\Definition\AbstractType, fieldNodes: \ArrayObject, info: \GraphQL\Type\Definition\ResolveInfo, path: int[]|string[], unaliasedPath: int[]|string[], result: mixed, contextValue: mixed) 

[spawnia]

We do mark public elements of our API with @api, so I would categorize this as internal and non-breaking.

[ruudk]

In that case, let's ship this! Way better indeed.