Skip to content

Remove pass-by-reference for $result in ReferenceExecutor #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove pass-by-reference for $result in ReferenceExecutor #1780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Executor/ReferenceExecutor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ protected function completeValue(
ResolveInfo $info,
array $path,
array $unaliasedPath,
&$result,
$result,
$contextValue
) {
// If result is an Error, throw a located error.
Expand Down Expand Up @@ -1007,7 +1007,7 @@ protected function completeListValue(
ResolveInfo $info,
array $path,
array $unaliasedPath,
iterable &$results,
iterable $results,
$contextValue
) {
$itemType = $returnType->getWrappedType();
Expand Down Expand Up @@ -1045,7 +1045,7 @@ protected function completeListValue(
*
* @return mixed
*/
protected function completeLeafValue(LeafType $returnType, &$result)
protected function completeLeafValue(LeafType $returnType, $result)
{
try {
return $returnType->serialize($result);
Expand Down Expand Up @@ -1079,7 +1079,7 @@ protected function completeAbstractValue(
ResolveInfo $info,
array $path,
array $unaliasedPath,
&$result,
$result,
$contextValue
) {
$typeCandidate = $returnType->resolveType($result, $contextValue, $info);
Expand Down Expand Up @@ -1213,7 +1213,7 @@ protected function completeObjectValue(
ResolveInfo $info,
array $path,
array $unaliasedPath,
&$result,
$result,
$contextValue
) {
// If there is an isTypeOf predicate function, call it with the
Expand All @@ -1229,7 +1229,7 @@ protected function completeObjectValue(
$fieldNodes,
$path,
$unaliasedPath,
&$result
$result
) {
if (! $isTypeOfResult) {
throw $this->invalidReturnTypeError($returnType, $result, $fieldNodes);
Expand Down Expand Up @@ -1296,7 +1296,7 @@ protected function collectAndExecuteSubfields(
\ArrayObject $fieldNodes,
array $path,
array $unaliasedPath,
&$result,
$result,
$contextValue
) {
$subFieldNodes = $this->collectSubFields($returnType, $fieldNodes);
Expand Down Expand Up @@ -1444,7 +1444,7 @@ protected function ensureValidRuntimeType(
$runtimeTypeOrName,
AbstractType $returnType,
ResolveInfo $info,
&$result
$result
): ObjectType {
$runtimeType = is_string($runtimeTypeOrName)
? $this->exeContext->schema->getType($runtimeTypeOrName)
Expand Down
Loading