Fix Logo Alignment in Sponsor Section #7568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
saurabh007007
force-pushed
the
fix-sponsors-logo-site
branch
from
d48f769 to
3fd9bb9
Compare
wneel
approved these changes
Mar 9, 2025
src/components/Support/Support.scss
Outdated
There was a problem hiding this comment.
100px may be too much on small devices ? Maybe try a responsive width too
|
@wneel can you review again 2025-03-10.11-13-12.mp4 |
yarn.lock
Outdated
| "@octokit/openapi-types" "^22.2.0" | ||
|
|
||
| "@octokit/types@^13.6.2", "@octokit/types@^13.7.0": | ||
| "@octokit/types@^13.0.0", "@octokit/types@^13.5.0", "@octokit/types@^13.6.2", "@octokit/types@^13.7.0": |
There was a problem hiding this comment.
Please remove changed from this file, thank you
There was a problem hiding this comment.
@alexander-akait i removed my changes please review it
saurabh007007
force-pushed
the
fix-sponsors-logo-site
branch
from
8b233d8 to
3b8f033
Compare
alexander-akait
previously approved these changes
Mar 10, 2025
src/components/Support/Support.jsx
Outdated
| @@ -276,6 +276,7 @@ export default class Support extends Component { | |||
| */ | |||
| _handleImgError(e) { | |||
| const imgNode = e.target; | |||
| console.error('Image failed to load:', imgNode.src); | |||
There was a problem hiding this comment.
@saurabh007007 Why we need it?
There was a problem hiding this comment.
It not need in production actually i was testing i will remove it now
saurabh007007
force-pushed
the
fix-sponsors-logo-site
branch
from
5a8af91 to
2d3cf63
Compare
alexander-akait
approved these changes
Mar 10, 2025
|
/cc @snitin315 |
|
@alexander-akait @wneel i have been loooking for the update |
snitin315
added a commit
that referenced
this pull request
Mar 14, 2025
snitin315
added a commit
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
describe your changes...
The sponsor Section was change where the logo are not aligned properly .
Previous Look (Before Changes):
Current Look (After Changes):
Files Modified:
Support.jsxSupport.scssFix Implemented:
Support.scssto ensure logos are aligned properly.Support.jsxto maintain a consistent layout.Please review the changes and let me know if any improvements are needed.