Skip to content

Fix Logo Alignment in Sponsor Section #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025
Merged

Fix Logo Alignment in Sponsor Section #7568

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fd9bb9
fixed the logo size of the sponsors sections
saurabh007007 Mar 8, 2025
3b8f033
fix(bug) fixed the ui for the small and devices and created it respon…
saurabh007007 Mar 10, 2025
2d3cf63
removed the log of image error handler
saurabh007007 Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/components/Support/Support.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,10 @@ export default class Support extends Component {
{rank === 'backer'
? 'Backers'
: rank === 'latest'
? 'Latest Sponsors'
: `${rank[0].toUpperCase()}${rank.slice(1)} ${
type === 'monthly' ? 'Monthly ' : ''
}Sponsors`}
? 'Latest Sponsors'
: `${rank[0].toUpperCase()}${rank.slice(1)} ${
type === 'monthly' ? 'Monthly ' : ''
}Sponsors`}
</h2>
<VisibilitySensor
delayedCall
Expand Down Expand Up @@ -240,7 +240,7 @@ export default class Support extends Component {
>
{
<img
className={`support__${rank}-avatar`}
className={`support__${rank}-avatar support__image`}
src={
inView && supporter.avatar ? supporter.avatar : SmallIcon
}
Expand Down Expand Up @@ -276,6 +276,7 @@ export default class Support extends Component {
*/
_handleImgError(e) {
const imgNode = e.target;
console.error('Image failed to load:', imgNode.src);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabh007007 Why we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It not need in production actually i was testing i will remove it now

if (imgNode.getAttribute('src') === SmallIcon) return;
imgNode.setAttribute('src', SmallIcon);
}
Expand Down
9 changes: 9 additions & 0 deletions src/components/Support/Support.scss
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100px may be too much on small devices ? Maybe try a responsive width too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
@import 'functions';

.support__image {
width: 100px; /* Set a uniform width */
height: 100px; /* Set a uniform height */
object-fit: contain; /* Ensures the image maintains its aspect ratio */
border-radius: 10px; /* Optional: Adds rounded corners */
background-color: white; /* Fallback background */
padding: 3px; /* Add some spacing */
}

.support {
display: flex;
flex-wrap: wrap;
Expand Down
9 changes: 1 addition & 8 deletions yarn.lock
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary

Original file line number Diff line number Diff line change
Expand Up @@ -2107,14 +2107,7 @@
"@octokit/plugin-request-log" "^5.3.1"
"@octokit/plugin-rest-endpoint-methods" "^13.0.0"

"@octokit/types@^13.0.0", "@octokit/types@^13.5.0":
version "13.5.0"
resolved "https://registry.yarnpkg.com/@octokit/types/-/types-13.5.0.tgz#4796e56b7b267ebc7c921dcec262b3d5bfb18883"
integrity sha512-HdqWTf5Z3qwDVlzCrP8UJquMwunpDiMPt5er+QjGzL4hqr/vBVY/MauQgS1xWxCDT1oMx1EULyqxncdCY/NVSQ==
dependencies:
"@octokit/openapi-types" "^22.2.0"

"@octokit/types@^13.6.2", "@octokit/types@^13.7.0":
"@octokit/types@^13.0.0", "@octokit/types@^13.5.0", "@octokit/types@^13.6.2", "@octokit/types@^13.7.0":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove changed from this file, thank you

Copy link
Contributor Author

@saurabh007007 saurabh007007 Mar 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait i removed my changes please review it

version "13.8.0"
resolved "https://registry.yarnpkg.com/@octokit/types/-/types-13.8.0.tgz#3815885e5abd16ed9ffeea3dced31d37ce3f8a0a"
integrity sha512-x7DjTIbEpEWXK99DMd01QfWy0hd5h4EN+Q7shkdKds3otGQP+oWE/y0A76i1OvH9fygo4ddvNf7ZvF0t78P98A==
Expand Down