fix: do not use heuristic fallback for "module-import" #18696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c951c98.
What kind of change does this PR introduce?
After discussing with @ahabhgk, we decided to correct the behavior introduced in #18660 that implicitly derive
"module-import"
fromexternalsPreset
. The original implementation was a compromise and had the following drawbacks:externalsPreset
, making the options less orthogonal.externalsPreset
does not fully align with the fallback intention.The revised implementation includes:
import
orimport()
dependency appears, it will simply fall back to themodule
type (or it can also fall back to theimport
type).To alter the external fallback, user can refine the handling by adding a test case like the one in this PR. User can customize the fallback type using
dependencyType
, for example:Did you add tests for your changes?
Yes.
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?
Yes, I'll update if this PR got merged.