Conversation
Member
|
Nice find and fix! Tested locally and working with dedupe + profiles! |
ikreymer
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3229
A bug was preventing browser profiles from being passed to the crawler args when dedupe was enabled. This PR fixes the conditional logic in the
crawler.yamltemplate so that dedupe and profile can be used together for crawls, but neither can be used in QA.The
save_profileconditional could be inside of the{% if profile_filename %}rather than using anandas I do here, but I was trying to reduce the number of nested conditionals to make it more readable, especially since the conditionals can't be indented to help in that respect.Testing
Nightly test run: https://github.com/webrecorder/browsertrix/actions/runs/23567830389