Pin Rust toolchain versions in ci.yml#23
Conversation
boivie
force-pushed
the
pin-toolchain
branch
5 times, most recently
from
96fcc2b to
84fa092
Compare
.github/workflows/ci.yml
Outdated
| @@ -15,6 +15,8 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - name: Install Rust | |||
| uses: dtolnay/rust-toolchain@stable | |||
There was a problem hiding this comment.
https://github.com/dtolnay/rust-toolchain?tab=readme-ov-file#inputs
When passing an explicit toolchain as an input instead of @Rev, you'll want to use "dtolnay/rust-toolchain@master" as the revision of the action.
But why would we want to pin it? Don't we want to detect such breakages? I'm also certain we will forget to uprev it in a steady phase.
There was a problem hiding this comment.
I think adding Dependabot would help us update those.
I am not a fan of doing a small change like #22 and getting failed CI simply because the toolchain has changed. Completely unrelated to my change. It makes the tree going from green to red without doing any changes to the code, and that's not very good developer experience IMO
There was a problem hiding this comment.
Fair, that would also help us uprev dependencies, which is good.
I'll let you chose if you want to go with dtolnay/rust-toolchain@1.92.0 or dtolnay/rust-toolchain@master.
Pin dtolnay/rust-toolchain actions to specific stable and nightly versions to prevent sudden build failures due to toolchain updates. Also fixed the new warnings found by updating the toolchain.
boivie
force-pushed
the
pin-toolchain
branch
from
84fa092 to
f69ad70
Compare
2 participants
Pin dtolnay/rust-toolchain actions to specific stable and nightly versions to prevent sudden build failures due to toolchain updates.
Also fixed the new warnings found by updating the toolchain.