Skip to content

Pin Rust toolchain versions in ci.yml #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boivie merged 1 commit into from
Dec 17, 2025
Merged

Pin Rust toolchain versions in ci.yml #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ on:

env:
CARGO_TERM_COLOR: always
STABLE_TOOLCHAIN: 1.92.0
NIGHTLY_TOOLCHAIN: nightly-2025-12-16

jobs:
build_and_test:
Expand All @@ -14,7 +16,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Install Rust
uses: dtolnay/rust-toolchain@stable
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.STABLE_TOOLCHAIN }}
- name: Build
run: cargo build --verbose
- name: Test
Expand All @@ -26,7 +30,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Install Rust
uses: dtolnay/rust-toolchain@nightly
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.NIGHTLY_TOOLCHAIN }}
- name: Sanity check fuzzers
run: |
cargo install cargo-fuzz
Expand All @@ -40,19 +46,20 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly
toolchain: ${{ env.NIGHTLY_TOOLCHAIN }}
components: rustfmt
- run: cargo +nightly fmt --all -- --check
- run: cargo fmt --all -- --check

check-clippy:
name: check (clippy)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.STABLE_TOOLCHAIN }}
components: clippy
- run: cargo clippy --all-features --all-targets -- -D warnings

Expand All @@ -61,7 +68,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.STABLE_TOOLCHAIN }}
# NOTE: We need to run `cargo test --doc` separately from normal tests:
# https://github.com/rust-lang/cargo/issues/6669
- name: Run doctests
Expand All @@ -79,7 +88,9 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Install Rust
uses: dtolnay/rust-toolchain@stable
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.STABLE_TOOLCHAIN }}
- name: Build and sanity test
run: |
cd dcsctp-cxx/
Expand Down
2 changes: 0 additions & 2 deletions src/packet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ pub enum ChunkParseError {

#[cfg(test)]
mod tests {
use super::*;

#[test]
fn read_big_endian() {
let a = &[1, 2, 3, 4, 5, 6, 7, 8];
Expand Down