Skip to content

feat: Preview by publishing to subdomain only aka staging #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 25, 2024
Merged

feat: Preview by publishing to subdomain only aka staging #4143

merged 8 commits into from
Sep 25, 2024

Conversation

@istarkov
Copy link
Member

@istarkov istarkov commented Sep 20, 2024 •
edited
Loading

Description

closes #2644

  • - Merge this fix: Resolve failing database tests on production environment #4156 into this PR

  • If the user has no custom domains:

    • Checkbox for Pro users is not shown.
    • Checkbox for Free users is shown but disabled (Tooltip enabled).

  • If the user has custom domains:

    • No Pro:
      • Checkboxes are shown disabled with Tooltips.
    • Pro:
      • Users can select any checkbox (no Tooltips).

  • Current indexing logic:

    • If a user has custom domain(s), upon publishing, the *.wstd.io domain will receive the meta tag: 
      <meta name="robots" content="noindex, nofollow">

  • - Fix example.com in tests (NEXT PR fix: Resolve failing database tests on production environment #4156)

  • - saas cleanup should be changed (we need to preserve latest build by domain now) (NEXT PR)

  • - Disable Publish Button if no checkboxes are selected

  • "With the Pro, you’ll gain the ability to publish to each domain independently!"

image

Steps for reproduction

Non Pro

  • Login as a new non Pro User pass:[email protected]
  • Create a new Project, Click Publish. Expect Disabled Checkbox with Tolltip is visible. Publish is Enabled.
image - Publish, check it published. - Add custom domain, Publish, check both are published.

Pro

  • Login as a Pro User pass
  • Open new Project. Expect No checkbox. One wstd domain.
image - Publish. Expect it published. - Add domain. See checkboxes visible after domain activated. - Publish. Expect both published. - Uncheck checkboxes, see publish button disabled. See it has tooltip.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from johnsicili September 23, 2024 16:24
@johnsicili
Copy link
Contributor

johnsicili commented Sep 23, 2024

It would appear that clicking on the copy button for DNS records refreshes the page:

refresh.mp4

Will continue testing just wanted to note that first

johnsicili
johnsicili approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Would be better UX to disable publishing button if none are checked
  2. I see adding the indication that its a Pro feature is left. I would really like to see that.

Otherwise good. Tested on custom domain in staging and works as expected

@istarkov
Make everything as action
8cbfc91 
Publish no loop

Update

Publishing done

Change Interface

Update exports

Exclude from search

Fix assets for saas

Fix

Fix static publish

Wait until published

Remove local refresh

Fix

Improve

Enable

Fix button types

Fix

Fix publish

Add tooltip support for checkboxes

Add tooltip checkbox
@istarkov istarkov changed the title feat: New publish form feat: Preview by publishing to subdomain only aka staging Sep 24, 2024
@istarkov istarkov requested a review from kof September 24, 2024 15:29
@istarkov istarkov marked this pull request as ready for review September 24, 2024 15:29
@istarkov istarkov mentioned this pull request Sep 24, 2024
Merged
7 tasks
@istarkov
fix: Resolve failing database tests on production environment (#4156)
e5e53bd 
## Description

Prev PR #4143 

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
@istarkov
::migrate:: do migration
e13621b
@istarkov istarkov merged commit 6ba6fc5 into main Sep 25, 2024
27 checks passed
@istarkov istarkov deleted the domain.staging branch September 25, 2024 07:24
@johnsicili johnsicili mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrySound TrySound TrySound approved these changes

@johnsicili johnsicili johnsicili approved these changes

@kof kof Awaiting requested review from kof

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

⤴️ Preview by publishing to subdomain only aka staging

4 participants

@istarkov @johnsicili @TrySound