Fix overwritten event entries in _webui_new_event_inf #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating new event info data and number, search for an empty event array entry rather than simply increasing the number and potentially overwriting existing info. This prevents intermittent double deletions when event blocking is disabled and many events of varying run durations occur in a short time. Also, increase the number of event entries that can be used to WEBUI_MAX_IDS which is the allocated events variable size.
AlbertShown
approved these changes
Oct 14, 2025
Member
|
Thank you @eric-boyd-protolabs for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating new event info data and number, search for an empty event array entry rather than simply increasing the number and potentially overwriting existing info. This prevents intermittent double deletions when event blocking is disabled and many events of varying run durations occur in a short time.
Also increase the number of event entries that can be used to WEBUI_MAX_IDS which is the allocated events array size.
Note that this change can introduce a deadlock (rather than a double delete) when the number of active events is greater than the event array size due to the introduction of the lock. That could probably be handled by introducing a event entry check counter and outer loop with a wait while the counter matches WEBUI_MAX_IDS. _webui_new_event_inf would block until an open slot became available.