Skip to content

Fix overwritten event entries in _webui_new_event_inf #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbertShown merged 1 commit into from
Oct 14, 2025
Merged

Fix overwritten event entries in _webui_new_event_inf #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/webui.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4804,10 +4804,23 @@ static char* _webui_get_full_path(_webui_window_t* win, const char* file) {

static size_t _webui_new_event_inf(_webui_window_t* win, webui_event_inf_t** event_inf) {
(*event_inf) = (webui_event_inf_t*)_webui_malloc(sizeof(webui_event_inf_t));
if (win->events_count > WEBUI_MAX_ARG)
win->events_count = 0;
size_t event_num = win->events_count++;

size_t event_num = win->events_count;

// Lock memory and search for next empty event entry
_webui_mutex_lock(&_webui.mutex_mem);

do {
event_num++;
if (win->events_count >= WEBUI_MAX_IDS)
event_num = 0;
} while (win->events[event_num] != NULL);

_webui_mutex_unlock(&_webui.mutex_mem);

win->events_count = event_num;
win->events[event_num] = (*event_inf);

return event_num;
}

Expand Down
Loading