Monster max_hit to array #629
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Context
looking into potentially using the
monsters.jsondump from this repo, but noticed a couple things 👀Issue 1:
max_hittaken as a stringeven tho the api provides multiple values, the script just takes the first one (which isn’t in a specific order)
response:

json

w/ fix

Issue 2: some npcs return back a single string of multiple max hits separated by line break tags
similar to issue 1, but here the script grabs the entire string, which is then parsed as an int on the frontend—grabbing just the first number (also no specific order).
response:

json

w/ fix

here's a dump of (diffs only) the re-scraped json monsters-diffs.txt
changes
scripts/generateMonsters.py:restructured
max_hitinto an array; split values on linebreaks when neededsrc/lib/Monsters.ts:updated
maxHitparsing forMonsterto grab largest value from the array (if passed array)