Skip to content

Conversation

cooltey
Copy link
Collaborator

@cooltey cooltey commented Sep 24, 2024

  • Created two database tables: Tab and PageBackStackItem
  • Created a custom serializer for the old PageBackStackItem that was stored in Prefs.tabs.
  • Move logic to TabHelp
  • TODO: ideal way to handle the coroutine process vs. the view updates without having a viewModel in the existing implementation?

Phabricator:
https://phabricator.wikimedia.org/T353656

@cooltey cooltey added the WIP Work in progress label Sep 24, 2024
@cooltey cooltey requested a review from dbrant as a code owner September 24, 2024 23:46
@cooltey cooltey added HOLD Will review as soon as other more pressing PRs are merged/released. and removed WIP Work in progress labels Sep 26, 2024
@cooltey
Copy link
Collaborator Author

cooltey commented Sep 26, 2024

A basic refactoring is completed. Pending discussion to see if we need to update the logic of handling tabs vs backstacks.

@cooltey cooltey requested a review from Williamrai as a code owner October 8, 2024 17:56
@cooltey cooltey removed the HOLD Will review as soon as other more pressing PRs are merged/released. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Development

Successfully merging this pull request may close these issues.

3 participants