Skip to content
Open
Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
117 commits
Select commit Hold shift + click to select a range
0dbb136
Convert Tabs to use database
cooltey Sep 24, 2024
2d8a9ed
Unused import
cooltey Sep 24, 2024
391ebce
Merge branch 'main' into tabs-database
cooltey Sep 25, 2024
f4625ab
Update database version
cooltey Sep 25, 2024
e6a1417
Update database version
cooltey Sep 25, 2024
11711dc
Merge branch 'main' into tabs-database
cooltey Sep 26, 2024
92d3e1c
Fix error
cooltey Sep 26, 2024
c8a440e
Clear and reset
cooltey Sep 26, 2024
918f977
Merge branch 'main' into tabs-database
cooltey Sep 30, 2024
799a68d
Fix errors
cooltey Sep 30, 2024
c775870
Merge branch 'main' into tabs-database
cooltey Sep 30, 2024
a409ed6
Merge branch 'main' into tabs-database
cooltey Oct 8, 2024
519a4f6
Merge branch 'main' into tabs-database
cooltey Oct 10, 2024
14b756a
Merge branch 'main' into tabs-database
Williamrai Oct 11, 2024
9395b28
Merge branch 'main' into tabs-database
cooltey Oct 15, 2024
8685967
Merge branch 'main' into tabs-database
cooltey Oct 16, 2024
9372430
Merge branch 'main' into tabs-database
cooltey Oct 22, 2024
bc26a8e
Merge branch 'main' into tabs-database
dbrant Oct 25, 2024
e5bffe6
Merge branch 'main' into tabs-database
dbrant Nov 6, 2024
ae2271d
Merge branch 'main' into tabs-database
cooltey Nov 14, 2024
4e81396
Merge branch 'main' into tabs-database
cooltey Nov 15, 2024
3c77685
Merge branch 'main' into tabs-database
dbrant Nov 15, 2024
76e5800
Merge branch 'main' into tabs-database
cooltey Nov 18, 2024
1d5d688
Merge branch 'main' into tabs-database
cooltey Nov 20, 2024
365c170
Merge branch 'main' into tabs-database
cooltey Nov 22, 2024
28d3eeb
Merge branch 'main' into tabs-database
cooltey Jan 15, 2025
c280e52
Merge branch 'main' into tabs-database
cooltey Jan 17, 2025
5f0f76d
Merge branch 'main' into tabs-database
cooltey Feb 11, 2025
51ceef3
Merge branch 'main' into tabs-database
cooltey Feb 13, 2025
6948bcd
Merge branch 'main' into tabs-database
Williamrai Feb 18, 2025
f7a41ed
Merge branch 'main' into tabs-database
cooltey Feb 18, 2025
16f7d73
Merge branch 'main' into tabs-database
cooltey Feb 18, 2025
ff100e2
Merge branch 'main' into tabs-database
cooltey Feb 19, 2025
5587987
Some checks update
cooltey Feb 19, 2025
b72b623
Merge branch 'main' into tabs-database
cooltey Feb 20, 2025
4ced578
Merge branch 'main' into tabs-database
cooltey Jun 23, 2025
63ec651
Merge branch 'main' into tabs-database
cooltey Jun 24, 2025
3da9909
Update json files
cooltey Jun 24, 2025
42938b6
Update the format a bit
cooltey Jun 24, 2025
c201d0a
Merge branch 'main' into tabs-database
cooltey Jun 25, 2025
dae54eb
utilize the db usage
cooltey Jun 26, 2025
92fbfb6
Fix parameter
cooltey Jun 26, 2025
6ff5747
Merge branch 'main' into tabs-database
cooltey Jun 26, 2025
a36da93
Merge branch 'main' into tabs-database
cooltey Jun 26, 2025
44f39d2
Merge branch 'main' into tabs-database
cooltey Jun 26, 2025
9eb5dca
Merge branch 'main' into tabs-database
cooltey Jun 30, 2025
bffba47
Merge branch 'main' into tabs-database
cooltey Jul 2, 2025
9137dec
Merge branch 'main' into tabs-database
cooltey Jul 8, 2025
c13ddf2
Merge branch 'main' into tabs-database
cooltey Jul 8, 2025
b288a53
Convert PageBackStackItem to an entity class
cooltey Jul 8, 2025
62f25c0
Update database for PageBackStackItem
cooltey Jul 8, 2025
d1c79ae
Replace backstack position with backstack id
cooltey Jul 9, 2025
7c4509f
Use list to store the backstack ids
cooltey Jul 9, 2025
93dea56
Update and consolidate
cooltey Jul 9, 2025
8034bc2
Refine the TabHelper
cooltey Jul 9, 2025
588aafe
Add logic of handling the orders
cooltey Jul 10, 2025
5db1e1b
refine commitState
cooltey Jul 10, 2025
a869b09
Merge branch 'main' into tabs-database
cooltey Jul 10, 2025
0dcd7c4
Update
cooltey Jul 10, 2025
7cbce16
Fix references
cooltey Jul 10, 2025
748deb6
Handle database SQL and fix error
cooltey Jul 11, 2025
af64bf9
Add a comment
cooltey Jul 11, 2025
7ecaa53
Merge branch 'main' into tabs-database
cooltey Jul 11, 2025
711afbc
Set up id correctly
cooltey Jul 11, 2025
bd4bbb5
Handling current tab
cooltey Jul 11, 2025
c0cb9e1
build pageTitle correctly
cooltey Jul 11, 2025
ef60b58
Refine migration
cooltey Jul 11, 2025
248f261
Fix lint
cooltey Jul 11, 2025
762d645
Add custom PageBackStackItemSerializer for old vs new format
cooltey Jul 11, 2025
9b439ff
Correctly passing the lifecycleowner
cooltey Jul 11, 2025
5194fad
Oops
cooltey Jul 11, 2025
0f0f59d
Add a todo comment for further improvement
cooltey Jul 11, 2025
5988cfd
Merge branch 'main' into tabs-database
cooltey Jul 14, 2025
dd50476
Add comments
cooltey Jul 14, 2025
e8cda31
A proper migration
cooltey Jul 14, 2025
881bcdb
Merge branch 'main' into tabs-database
cooltey Jul 14, 2025
a11f1a6
Get correct index
cooltey Jul 15, 2025
b6a5bbd
unused import
cooltey Jul 15, 2025
2053dd3
Merge branch 'main' into tabs-database
cooltey Jul 15, 2025
de0d7b6
Create viewModel for TabActivity
cooltey Jul 16, 2025
8e4fa10
regular lifecycle
cooltey Jul 16, 2025
11ea48b
Delete state
cooltey Jul 16, 2025
94a50e9
Merge branch 'main' into tabs-database
cooltey Jul 16, 2025
5c3a696
Handle tabs in viewModel
cooltey Jul 16, 2025
6e14843
visibility
cooltey Jul 16, 2025
6f6f4c4
Re-arrange orders correctly
cooltey Jul 16, 2025
98e9461
Final commit for TabViewModel
cooltey Jul 17, 2025
8415bd0
Adjust the animation
cooltey Jul 17, 2025
f2476fb
Merge branch 'main' into tabs-database
cooltey Jul 17, 2025
6a33ae8
Put coroutine in TabCountView
cooltey Jul 17, 2025
7c57fbe
Merge branch 'tabs-database' of github.com:wikimedia/apps-android-wik…
cooltey Jul 17, 2025
5c4e777
Fix lint
cooltey Jul 17, 2025
f1ab7cf
Add another uistate for undo actions
cooltey Jul 17, 2025
ea4f415
Try to make tab count updated correctly
cooltey Jul 17, 2025
630fe08
Merge branch 'main' into tabs-database
cooltey Jul 17, 2025
843e93c
Update the tab count properly
cooltey Jul 17, 2025
153689d
Merge branch 'tabs-database' of github.com:wikimedia/apps-android-wik…
cooltey Jul 17, 2025
742b733
Handle foreground vs background
cooltey Jul 17, 2025
ffcc7f9
rename the function and order better
cooltey Jul 18, 2025
8147f73
prep for pagefragment
cooltey Jul 18, 2025
9563e30
something more
cooltey Jul 18, 2025
9dbd051
Merge branch 'main' into tabs-database
cooltey Jul 18, 2025
f4e250a
add runBlocking first
cooltey Jul 18, 2025
26613a2
Merge branch 'tabs-database' of github.com:wikimedia/apps-android-wik…
cooltey Jul 18, 2025
3fdedc3
Merge branch 'main' into tabs-database
cooltey Jul 18, 2025
2197052
Fix errors
cooltey Jul 18, 2025
2d42b57
Fix lint
cooltey Jul 18, 2025
51b6631
Handling moveToForeground correctly
cooltey Jul 18, 2025
ac90063
New tab
cooltey Jul 18, 2025
dc4de2b
Further logic change
cooltey Jul 18, 2025
132c96a
Handling tabs in pageFragment
cooltey Jul 18, 2025
e6e7d64
handle reload issue
cooltey Jul 19, 2025
61dd964
Create new tab
cooltey Jul 19, 2025
a3e7d5e
Merge branch 'main' into tabs-database
cooltey Jul 21, 2025
0f7a0b5
Merge branch 'main' into tabs-database
cooltey Jul 28, 2025
94a9177
Merge branch 'main' into tabs-database
cooltey Aug 19, 2025
65fcfbc
Merge branch 'main' into tabs-database
cooltey Aug 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions app/schemas/org.wikipedia.database.AppDatabase/26.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"formatVersion": 1,
"database": {
"version": 26,
"identityHash": "16a25d36f8cbc3a8743699b56a550c06",
"identityHash": "d042bcf4c06c8727f99ac4c827e5a691",
"entities": [
{
"tableName": "HistoryEntry",
Expand Down Expand Up @@ -536,12 +536,44 @@
},
"indices": [],
"foreignKeys": []
},
{
"tableName": "Tab",
"createSql": "CREATE TABLE IF NOT EXISTS `${TABLE_NAME}` (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, `backStack` TEXT NOT NULL, `backStackPosition` INTEGER NOT NULL)",
"fields": [
{
"fieldPath": "id",
"columnName": "id",
"affinity": "INTEGER",
"notNull": true
},
{
"fieldPath": "backStack",
"columnName": "backStack",
"affinity": "TEXT",
"notNull": true
},
{
"fieldPath": "backStackPosition",
"columnName": "backStackPosition",
"affinity": "INTEGER",
"notNull": true
}
],
"primaryKey": {
"autoGenerate": true,
"columnNames": [
"id"
]
},
"indices": [],
"foreignKeys": []
}
],
"views": [],
"setupQueries": [
"CREATE TABLE IF NOT EXISTS room_master_table (id INTEGER PRIMARY KEY,identity_hash TEXT)",
"INSERT OR REPLACE INTO room_master_table (id,identity_hash) VALUES(42, '16a25d36f8cbc3a8743699b56a550c06')"
"INSERT OR REPLACE INTO room_master_table (id,identity_hash) VALUES(42, 'd042bcf4c06c8727f99ac4c827e5a691')"
]
}
}
Loading
Loading