-
Notifications
You must be signed in to change notification settings - Fork 292
Maven clean up #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Maven clean up #2285
Conversation
581d9d4 to
9e9fbfb
Compare
9e9fbfb to
bd4ecac
Compare
e53c4a1 to
26e393c
Compare
|
@jasondlee Can you pls put your changes to your develop branch, we will then be able to see it works and preview the changes at http://<YOUR_GITHUB_USERNAME>.github.io/wildfly-elytron/blog |
|
| paginate: true | ||
| --- | ||
| {@io.quarkiverse.roq.frontmatter.runtime.model.NormalPage page} | ||
| <div class="blog-page grid-wrapper"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jasondlee , in the page preview on your account, the tags stopped working, if you click on the tag (all blogs contain some tags) then the 404 gets returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pffft. I'll look into that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasondlee did you manage to take a look so maybe we can get this merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
26e393c to
cef9920
Compare
Add enforcer plugin to enforce minimum JDK version Remove duplicate dependencies Set default goal to test Update Roq version Add workflow to test site build for PRs Archive generated site after test Template clean up Remove unused template Update Quarkus
cef9920 to
015cc59
Compare
|
Thanks @jasondlee ! Only minor issue I noticed is that profile pics of authors no longer appear on http://localhost:8080/wildfly-elytron/blog/. Interestingly, when I click on any tag, the pictures reappear. Btw the latest blog had invalid tags so you can ignore that as I just merged a fix #2357 |
I see profile pics here: https://jasondlee.github.io/wildfly-elytron/blog/ |
@jasondlee Hm I tried again and I do not see them when I build your |
Uh oh!
There was an error while loading. Please reload this page.