-
Notifications
You must be signed in to change notification settings - Fork 292
Maven clean up #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasondlee
wants to merge
1
commit into
wildfly-security:develop
Choose a base branch
from
jasondlee:maven-enforcer
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Maven clean up #2285
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test site build | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'temurin' | ||
| cache: maven | ||
| - name: Build with Maven | ||
| run: mvn --batch-mode test | ||
| - name: Archive generated site | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: generated-site | ||
| path: ./target/roq/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| --- | ||
| twitter_username: WildFlyAS | ||
| --- | ||
|
|
||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,4 +28,3 @@ <h3></h3> | |
| {/if} | ||
| {/for} | ||
| </div> | ||
| {/let} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| <div class="share-page"> | ||
| <a class="share-linkedin" href="https://www.linkedin.com/shareArticle?mini=true&url={include.url}&title={include.title}" rel="nofollow" target="_blank" title="Share on LinkedIn"> | ||
| <div class="share-page"> | ||
| <a class="share-linkedin" href="https://www.linkedin.com/shareArticle?mini=true&url={url}&title={title}" rel="nofollow" target="_blank" title="Share on LinkedIn"> | ||
| <i class="fab fa-linkedin"></i> | ||
| </a> | ||
| <a class="share-twitter" href="https://twitter.com/intent/tweet?text={include.title}&url={include.url}&via={site.twitter_username}&related={site.twitter_username}" rel="nofollow" target="_blank" title="Share on Twitter"> | ||
| <a class="share-twitter" href="https://twitter.com/intent/tweet?text={title}&url={url}&via={page.data.twitter_username}&related={page.data.twitter_username}" rel="nofollow" target="_blank" title="Share on Twitter"> | ||
| <i class="fab fa-twitter-square"></i> | ||
| </a> | ||
| <a class="share-facebook" href="https://facebook.com/sharer.php?u={include.url}" rel="nofollow" target="_blank" title="Share on Facebook"> | ||
| <a class="share-facebook" href="https://facebook.com/sharer.php?u={url}" rel="nofollow" target="_blank" title="Share on Facebook"> | ||
| <i class="fab fa-facebook-square"></i> | ||
| </a> | ||
| <a class="share-reddit" href="http://www.reddit.com/submit?url={include.url}" onclick="window.open(this.href, 'pop-up', 'left=20,top=20,width=900,height=500,toolbar=1,resizable=0'); return false;" title="Share on Reddit" > | ||
| <a class="share-reddit" href="http://www.reddit.com/submit?url={url}" onclick="window.open(this.href, 'pop-up', 'left=20,top=20,width=900,height=500,toolbar=1,resizable=0'); return false;" title="Share on Reddit" > | ||
| <i class="fab fa-reddit-square"></i> | ||
| </a> | ||
| <a class="share-email" href="mailto:?subject={include.title}&body={include.title} {include.url}" title="Share via Email" > | ||
| <a class="share-email" href="mailto:?subject={title}&body={title} {url}" title="Share via Email" > | ||
| <i class="fas fa-envelope-square"></i> | ||
| </a> | ||
| </div> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jasondlee , in the page preview on your account, the tags stopped working, if you click on the tag (all blogs contain some tags) then the 404 gets returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pffft. I'll look into that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasondlee did you manage to take a look so maybe we can get this merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Skyllarr @darranl Give it a go now.