Skip to content

fix: restore flat powershell module detection with file existence check#8371

Merged
rubenfiszel merged 1 commit intomainfrom
fix-powershell-windmillclient-module-loa
Mar 14, 2026
Merged

fix: restore flat powershell module detection with file existence check#8371
rubenfiszel merged 1 commit intomainfrom
fix-powershell-windmillclient-module-loa

Conversation

@rubenfiszel
Copy link
Contributor

Summary

  • Followup to fix: powershell WindmillClient module loading on Windows workers #8370. The removed "unknown" fallback in get_module_versions() was handling flat module installations (files directly in module dir, no version subdirectory). Restores that case but now verifies .psd1/.psm1 files actually exist instead of blindly treating any directory as installed.

Test plan

  • Module installed with version subdirectory (WindmillClient/1.655.0/WindmillClient.psd1) is detected
  • Module installed flat (SomeModule/SomeModule.psd1) is detected
  • Empty module directory is NOT detected as installed

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@claude
Copy link
Contributor

claude bot commented Mar 14, 2026

Reviewing PR #8371

  • Read PR diff and changed files
  • Review code quality and logic
  • Post review feedback

View job run

@rubenfiszel rubenfiszel merged commit daade37 into main Mar 14, 2026
13 of 14 checks passed
@rubenfiszel rubenfiszel deleted the fix-powershell-windmillclient-module-loa branch March 14, 2026 23:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant