feat: Create folders in files list (WPB-17272)#4007
Merged
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
ohassine
changed the title
ohassine
changed the title
…-attachement-type # Conflicts: # kalium
…-attachement-type # Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/createfolder/CreateFolderScreen.kt
# Conflicts: # features/cells/src/main/java/com/wire/android/feature/cells/ui/AllFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/download/DownloadFileBottomSheet.kt # features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt # kalium
ohassine
requested review from
a team,
MohamadJaara,
mathias-niboulies,
saleniuk,
sbakhtiarov,
typfel and
yamilmedina
and removed request for
a team,
mathias-niboulies and
typfel
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4007 +/- ##
========================================
Coverage 46.00% 46.00%
========================================
Files 520 520
Lines 18124 18124
Branches 3053 3053
========================================
Hits 8338 8338
Misses 8921 8921
Partials 865 865
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
|
Built wire-android-staging-compat-pr-4007.apk is available for download |
Contributor
|
Built wire-android-dev-debug-pr-4007.apk is available for download |
ohassine
changed the title
This was referenced May 12, 2025
Contributor
|
Built wire-android-staging-compat-pr-4007.apk is available for download |
Contributor
|
Built wire-android-dev-debug-pr-4007.apk is available for download |
sbakhtiarov
approved these changes
May 13, 2025
features/cells/src/main/java/com/wire/android/feature/cells/ui/model/BottomSheetAction.kt
Show resolved
Hide resolved
Garzas
reviewed
May 13, 2025
Contributor
Garzas
left a comment
Garzas
left a comment
There was a problem hiding this comment.
Looking good 🚀 Just small comments about todos and arguments
features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
Show resolved
Hide resolved
features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
Outdated
Show resolved
Hide resolved
features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
Outdated
Show resolved
Hide resolved
|
yamilmedina
approved these changes
May 13, 2025
Contributor
|
Built wire-android-staging-compat-pr-4007.apk is available for download |
Contributor
|
Built wire-android-dev-debug-pr-4007.apk is available for download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Create folders
Show folders in conversation files
I have added automated test to this contribution
Attachments (Optional)
Screen_recording_20250512_154316.webm
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.