Skip to content

fix: files percent encoding - WPB-23207 #4244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilhelmOks merged 2 commits into from
Feb 3, 2026
+4 −2
Merged

fix: files percent encoding - WPB-23207 #4244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40116f9
WPB-23207: removing percent encoding for node rename
WilhelmOks Feb 2, 2026
d7d96bc
format
WilhelmOks Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...Messaging/Sources/WireMessagingDomain/WireCells/UseCases/WireCellsRenameNodeUseCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,11 @@ package struct WireCellsRenameNodeUseCase: WireCellsRenameNodeUseCaseProtocol {
targetPath = directory.appendingPathComponent("\(newFilename).\(pathExtension)")
}

let path = targetPath.absoluteString.removingPercentEncoding ?? targetPath.absoluteString

// Checks whether the path doesn't already exist.
let preCheckResult = try await nodesRepository.preCheck(
nodePath: targetPath.absoluteString,
nodePath: path,
findAvailablePath: false
)

Expand All @@ -81,7 +83,7 @@ package struct WireCellsRenameNodeUseCase: WireCellsRenameNodeUseCaseProtocol {
// Renames the file on the server.
let didRenameFile = try await nodesRepository.renameNode(
nodeID: nodeID,
targetPath: targetPath.absoluteString
targetPath: path
)

guard didRenameFile else {
Expand Down
Loading