fix: files percent encoding - WPB-23207

[WilhelmOks]

WPB-23207 [iOS] Files and folders with spaces and special characters created on iOS have wrong names on Android and Web

Issue

Renaming files was adding percent encoding like %20 for space .
This was because the file path was wrapped into a URL and then was converted to a String using .absoluteString.
I fixed that by calling .removingPercentEncoding before that string is used.

The percent encoding isn't visible in iOS but you can check it in the web app.

I also tested creating folders, moving folders and uploading drafts. None of those cases have that issue in 4.14, so no code needs to be changed there.

We should also test if creating new files for Collabora (templates) is affected, but that feature is not in 4.14.

Testing

Creating, moving and renaming files and folders should not cause the file names to have percent encodings. Percent encodings are only visible in the web app (and probably Android)

---

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

---

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

• Make sure you use the API for UI elements that support large fonts.
• All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
• New UI elements have Accessibility strings for VoiceOver.

[github-actions]

Test Results

2 120 tests   2 093 ✅  2m 37s ⏱️
  354 suites     27 💤
    2 files        0 ❌

Results for commit d7d96bc.

♻️ This comment has been updated with latest results.

Summary: workflow run #21631340420
Allure report (download zip): html-report-27494-fix_WPB-23207-files-percent-encoding

[jullianm]

Nice work, thanks for fixing this.

[WilhelmOks]

Will create a new PR with base release/cycle-4.15

[WilhelmOks]

reopening since this should go into 4.14.1 hotfix