Skip to content

fix: files percent encoding - WPB-23207 🍒#4255

Merged
WilhelmOks merged 1 commit intorelease/cycle-4.15from
fix/WPB-23207-files-percent-encoding-cherry-pick
Feb 3, 2026
Merged

fix: files percent encoding - WPB-23207 🍒#4255
WilhelmOks merged 1 commit intorelease/cycle-4.15from
fix/WPB-23207-files-percent-encoding-cherry-pick

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 3, 2026

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-23207 [iOS] Files and folders with spaces and special characters created on iOS have wrong names on Android and Web

Issue

Renaming files was adding percent encoding like %20 for space .
This was because the file path was wrapped into a URL and then was converted to a String using .absoluteString.
I fixed that by calling .removingPercentEncoding before that string is used.

The percent encoding isn't visible in iOS but you can check it in the web app.

I also tested creating folders, moving folders and uploading drafts. None of those cases have that issue in 4.14, so no code needs to be changed there.

We should also test if creating new files for Collabora (templates) is affected, but that feature is not in 4.14.

Testing

Creating, moving and renaming files and folders should not cause the file names to have percent encodings. Percent encodings are only visible in the web app (and probably Android)


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@WilhelmOks
Copy link
Collaborator

closing and reopening to trigger autoapprove

@WilhelmOks WilhelmOks closed this Feb 3, 2026
@WilhelmOks WilhelmOks reopened this Feb 3, 2026
Copy link
Collaborator

@zenkins zenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved cherry-pick PR 🍒.

@WilhelmOks WilhelmOks enabled auto-merge (squash) February 3, 2026 13:44
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 3, 2026

Test Results

2 122 tests   2 095 ✅  2m 36s ⏱️
  354 suites     27 💤
    2 files        0 ❌

Results for commit 6c9ff97.

Summary: workflow run #21632587073
Allure report (download zip): html-report-27499-fix_WPB-23207-files-percent-encoding-cherry-pick

@WilhelmOks WilhelmOks merged commit 950e290 into release/cycle-4.15 Feb 3, 2026
12 checks passed
@WilhelmOks WilhelmOks deleted the fix/WPB-23207-files-percent-encoding-cherry-pick branch February 3, 2026 14:00
zenkins pushed a commit that referenced this pull request Feb 3, 2026
Co-authored-by: Wilhelm Oks <50032051+WilhelmOks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants